Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1078663002: Deflake the whitespace-length-invalid test (Closed)

Created:
5 years, 8 months ago by Erik Dahlström (inactive)
Modified:
5 years, 8 months ago
Reviewers:
falken, fs
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move test from fast to svg/parser, and split it. This should hopefully make the individual parts fast enough to not timeout. The slowness is most likely due to the amount of console output that this test generates. BUG=446356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193533

Patch Set 1 #

Patch Set 2 : split test in two #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4605 lines, -14276 lines) Patch
M LayoutTests/FlakyTests View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-length-invalid.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-length-invalid-expected.txt View 1 chunk +0 lines, -9603 lines 0 comments Download
A + LayoutTests/svg/parser/whitespace-length-invalid-1.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt View 1 1 chunk +3603 lines, -0 lines 0 comments Download
A + LayoutTests/svg/parser/whitespace-length-invalid-2.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt View 1 41 chunks +1000 lines, -4600 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Erik Dahlström (inactive)
5 years, 8 months ago (2015-04-09 12:55:44 UTC) #3
fs
lgtm There appear to be "upload errors" on some files. May want to try to ...
5 years, 8 months ago (2015-04-09 13:01:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078663002/20001
5 years, 8 months ago (2015-04-10 08:18:00 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 11:11:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193533

Powered by Google App Engine
This is Rietveld 408576698