Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1078653002: Blacklist tests due to optimizing toplevel with --always-opt. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blacklist tests due to optimizing toplevel with --always-opt. Those two tests fail in gc-stress and custom snapshot (embedding mjsunit.js). This is likely due to different GC timing with the custom snapshot. R=mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fd8d0d1419661f362cc12d3f37965a480f93ebee Cr-Commit-Position: refs/heads/master@{#27688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-09 08:44:19 UTC) #1
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-04-09 08:47:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078653002/1
5 years, 8 months ago (2015-04-09 08:47:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 08:47:33 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 08:47:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd8d0d1419661f362cc12d3f37965a480f93ebee
Cr-Commit-Position: refs/heads/master@{#27688}

Powered by Google App Engine
This is Rietveld 408576698