Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: src/heap/heap.cc

Issue 1078623004: Add CHECKs that the array buffers list is always sorted new to old (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index a50db96b8b9c71a876afda64276bea2b7e5a41a5..a2fd76e7e5102884b425da66c0be13573e900752 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1722,7 +1722,6 @@ void Heap::ProcessArrayBuffers(WeakObjectRetainer* retainer,
this, array_buffers_list(), retainer, stop_after_young);
set_array_buffers_list(array_buffer_obj);
-#ifdef DEBUG
// Verify invariant that young array buffers come before old array buffers
// in array buffers list if there was no promotion failure.
Object* undefined = undefined_value();
@@ -1733,10 +1732,9 @@ void Heap::ProcessArrayBuffers(WeakObjectRetainer* retainer,
if (!old_objects_recorded) {
old_objects_recorded = !InNewSpace(next);
}
- DCHECK((InNewSpace(next) && !old_objects_recorded) || !InNewSpace(next));
+ CHECK((InNewSpace(next) && !old_objects_recorded) || !InNewSpace(next));
next = JSArrayBuffer::cast(next)->weak_next();
}
-#endif
}
« no previous file with comments | « no previous file | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698