Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3347)

Unified Diff: build/android/provision_devices.py

Issue 1078623003: [Android] Make provision_devices.KillHostHeartbeat public again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/provision_devices.py
diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py
index 049726426ab8e989a4d4fb14b3f7ff3802982d34..ecb3f20648b26f3a416053c361f8669cee82aa98 100755
--- a/build/android/provision_devices.py
+++ b/build/android/provision_devices.py
@@ -117,7 +117,7 @@ def WipeDevice(device, options):
as_root=True).splitlines()
try:
device.RunShellCommand(['wipe', 'data'],
- as_root=True, check_return=True, retries=0)
+ as_root=True, check_return=True)
except device_errors.CommandFailedError:
logging.exception('Possible failure while wiping the device. '
'Attempting to continue.')
@@ -253,14 +253,14 @@ def _PushAndLaunchAdbReboot(device, target):
def _LaunchHostHeartbeat():
# Kill if existing host_heartbeat
- _KillHostHeartbeat()
+ KillHostHeartbeat()
# Launch a new host_heartbeat
logging.info('Spawning host heartbeat...')
subprocess.Popen([os.path.join(constants.DIR_SOURCE_ROOT,
'build/android/host_heartbeat.py')])
-def _KillHostHeartbeat():
+def KillHostHeartbeat():
ps = subprocess.Popen(['ps', 'aux'], stdout=subprocess.PIPE)
stdout, _ = ps.communicate()
matches = re.findall('\\n.*host_heartbeat.*', stdout)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698