Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1078603002: waitUntil() and respondWith() should propagate error/exception reports (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
haraken, falken, yhirano, horo
CC:
blink-reviews, tzik, vivekg, apavlov+blink_chromium.org, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, vivekg_samsung, yurys+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, nhiroki, michaeln, serviceworker-reviews, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

waitUntil() and respondWith() should propagate error/exception reports This patch makes WaitUntilObserver and RespondWithObserver "rethrow" errors when rejection handler is called. As a result, messages are reported in worker console. BUG=359423 TEST=https://codereview.chromium.org/1081953004/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193762

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Remove inspector tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M Source/bindings/core/v8/ScriptPromise.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-09 06:53:47 UTC) #2
haraken
https://codereview.chromium.org/1078603002/diff/1/Source/modules/serviceworkers/RespondWithObserver.cpp File Source/modules/serviceworkers/RespondWithObserver.cpp (right): https://codereview.chromium.org/1078603002/diff/1/Source/modules/serviceworkers/RespondWithObserver.cpp#newcode123 Source/modules/serviceworkers/RespondWithObserver.cpp:123: return m_resolveType == Rejected Can we restructure the code ...
5 years, 8 months ago (2015-04-09 06:57:33 UTC) #4
falken
Does this cause a behavior change other than console logging? For example, does it mean ...
5 years, 8 months ago (2015-04-09 07:12:28 UTC) #6
Kunihiko Sakamoto
On 2015/04/09 07:12:28, falken wrote: > Does this cause a behavior change other than console ...
5 years, 8 months ago (2015-04-09 09:21:24 UTC) #7
falken
On 2015/04/09 09:21:24, Kunihiko Sakamoto wrote: > On 2015/04/09 07:12:28, falken wrote: > > Does ...
5 years, 8 months ago (2015-04-10 03:07:54 UTC) #8
horo
When I executed "./blink/tools/run_layout_tests.sh http/tests/inspector/service-workers/" in my linux machine, a timeout error occured in the ...
5 years, 8 months ago (2015-04-10 03:29:39 UTC) #9
yhirano
https://codereview.chromium.org/1078603002/diff/20001/LayoutTests/http/tests/inspector/service-workers/rejection-message-for-respond-with.html File LayoutTests/http/tests/inspector/service-workers/rejection-message-for-respond-with.html (right): https://codereview.chromium.org/1078603002/diff/20001/LayoutTests/http/tests/inspector/service-workers/rejection-message-for-respond-with.html#newcode1 LayoutTests/http/tests/inspector/service-workers/rejection-message-for-respond-with.html:1: <html> This test file doesn't conform to the sreviceworker ...
5 years, 8 months ago (2015-04-13 02:03:41 UTC) #10
Kunihiko Sakamoto
Since inspector tests are slow and console sniffing is somewhat unreliable at the moment, I ...
5 years, 8 months ago (2015-04-14 06:10:15 UTC) #11
yhirano
lgtm
5 years, 8 months ago (2015-04-14 08:48:30 UTC) #12
Kunihiko Sakamoto
Horo-san, PTAL?
5 years, 8 months ago (2015-04-15 03:33:27 UTC) #13
horo
lgtm
5 years, 8 months ago (2015-04-15 04:07:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078603002/40001
5 years, 8 months ago (2015-04-15 04:12:39 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 08:55:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193762

Powered by Google App Engine
This is Rietveld 408576698