[Webapp Refactor] Clean up remoting.Clipboard.

remoting/webapp/crd/js/client_plugin_impl.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class that wraps low-level details of interacting with the client plugin.
  *
  * This abstracts a <embed> element and controls the plugin which does
  * the actual remoting work. It also handles differences between
@@ skipping 26 matching lines @@
   this.plugin_ = remoting.ClientPluginImpl.createPluginElement_();
   this.plugin_.id = 'session-client-plugin';
   container.appendChild(this.plugin_);
 
   /** @private {Array<string>} */
   this.requiredCapabilities_ = requiredCapabilities;
 
   /** @private {remoting.ClientPlugin.ConnectionEventHandler} */
   this.connectionEventHandler_ = null;
 
-  /**
-   * @param {string} data Remote gnubbyd data.
-   * @private
-   */
-  this.onGnubbyAuthHandler_ = function(data) {};

[kelvinp, 2015/04/09 00:28:26]

Removed as this is not referenced else where.

-  /**
-   * @param {string} url
-   * @param {number} hotspotX
-   * @param {number} hotspotY
-   * @private
-   */
-  this.updateMouseCursorImage_ = function(url, hotspotX, hotspotY) {};
-  /**
-   * @param {string} data Remote cast extension message.
-   * @private
-   */
-  this.onCastExtensionHandler_ = function(data) {};
+  /** @private {?function(string, number, number)} */
+  this.updateMouseCursorImage_ = base.doNothing;
+  /** @private {?function(string, string)} */
+  this.updateClipboardData_ = base.doNothing;
+  /** @private {?function(string)} */
+  this.onCastExtensionHandler_ = base.doNothing;
   /** @private {?function({rects:Array<Array<number>>}):void} */
   this.debugRegionHandler_ = null;
 
   /** @private {number} */
   this.pluginApiVersion_ = -1;
   /** @private {Array<string>} */
   this.pluginApiFeatures_ = [];
   /** @private {number} */
   this.pluginApiMinVersion_ = -1;
   /** @private {!Array<string>} */
@@ skipping 87 matching lines @@
 };
 
 /**
  * @param {function(string, number, number):void} handler
  */
 remoting.ClientPluginImpl.prototype.setMouseCursorHandler = function(handler) {
   this.updateMouseCursorImage_ = handler;
 };
 
 /**
+ * @param {function(string, string):void} handler
+ */
+remoting.ClientPluginImpl.prototype.setClipboardHandler = function(handler) {
+  this.updateClipboardData_ = handler;
+};
+
+/**
  * @param {?function({rects:Array<Array<number>>}):void} handler
  */
 remoting.ClientPluginImpl.prototype.setDebugDirtyRegionHandler =
     function(handler) {
   this.debugRegionHandler_ = handler;
   this.plugin_.postMessage(JSON.stringify(
       { method: 'enableDebugRegion', data: { enable: handler != null } }));
 };
 
 /**
@@ skipping 122 matching lines @@
     base.getNumberAttr(message.data, 'encodeLatency');
     base.getNumberAttr(message.data, 'decodeLatency');
     base.getNumberAttr(message.data, 'renderLatency');
     base.getNumberAttr(message.data, 'roundtripLatency');
     this.perfStats_ =
         /** @type {remoting.ClientSession.PerfStats} */ (message.data);
 
   } else if (message.method == 'injectClipboardItem') {
     var mimetype = base.getStringAttr(message.data, 'mimeType');
     var item = base.getStringAttr(message.data, 'item');
-    if (remoting.clipboard) {
-      remoting.clipboard.fromHost(mimetype, item);
-    }
+    this.updateClipboardData_(mimetype, item);
 
   } else if (message.method == 'onFirstFrameReceived') {
     if (remoting.clientSession) {
       remoting.clientSession.onFirstFrameReceived();
     }
 
   } else if (message.method == 'fetchPin') {
     // The pairingSupported value in the dictionary indicates whether both
     // client and host support pairing. If the client doesn't support pairing,
     // then the value won't be there at all, so give it a default of false.
@@ skipping 547 matching lines @@
 remoting.DefaultClientPluginFactory.prototype.preloadPlugin = function() {
   if (remoting.settings.CLIENT_PLUGIN_TYPE != 'pnacl') {
     return;
   }
 
   var plugin = remoting.ClientPluginImpl.createPluginElement_();
   plugin.addEventListener(
       'loadend', function() { document.body.removeChild(plugin); }, false);
   document.body.appendChild(plugin);
 };