[Webapp Refactor] Clean up remoting.Clipboard.

[Webapp Refactor] Clean up remoting.Clipboard.

Currently, remoting.Clipboard is exposed as a global, such that it can hook
events across different files, e.g. remoting.js, client_plugin_impl.js, application.js

This CL moves clean up the file by:
1. Only create an instance of the clipboard when a session is connected.  This removes
   the startSession() method on the clipboard.
2. Hook all events (copy/paste/focus changes) from within remoting.clipboard, which
   eliminates the need to have a global and effectively makes all its methods private.
3. Style cleanups, use single quotes for strings, make sure private variables are
   post-fixed with underscores.

BUG=475317
Committed: https://crrev.com/be79f477e4d1e66e2d80e7bcd5f9689f3fbbcefc
Cr-Commit-Position: refs/heads/master@{#324354}

[kelvinp, 2015-04-09 00:25:51]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-04-09 00:28:26]

PTAL

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/base/js/app...
File remoting/webapp/base/js/application.js (left):

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/base/js/app...
remoting/webapp/base/js/application.js:162: remoting.clipboard.startSession();
The clipboard is now created in remoting.ConnectedView.

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:51: this.onGnubbyAuthHandler_ =
function(data) {};
Removed as this is not referenced else where.

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/clip...
File remoting/webapp/crd/js/clipboard.js (right):

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/clip...
remoting/webapp/crd/js/clipboard.js:46: new base.DomEventHook(plugin.element(),
'focus',
moved from connectedView.js

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/clip...
remoting/webapp/crd/js/clipboard.js:48: new base.DomEventHook(window, 'paste',
this.onPaste_.bind(this), false),
moved from remoting.js

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/conn...
File remoting/webapp/crd/js/connected_view.js (left):

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/conn...
remoting/webapp/crd/js/connected_view.js:46: this.onPluginGotFocus_.bind(this),
false),
moved to clipboard.js

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/remo...
File remoting/webapp/crd/js/remoting.js (left):

https://codereview.chromium.org/1078563002/diff/1/remoting/webapp/crd/js/remo...
remoting/webapp/crd/js/remoting.js:40: window.addEventListener('paste',
pluginGotPaste_, false);
moved to clipboard.js

[Jamie, 2015-04-09 00:35:20]

Nice cleanup! LGTM

[kelvinp, 2015-04-09 01:09:32]

You are welcome.
Thank you for the quick turn around.
FYI

[kelvinp, 2015-04-09 01:09:36]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-04-09 01:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1078563002/#ps20001
(title: "Remove remoting.ClientSession.sendClipboardItem for real")

[commit-bot: I haz the power, 2015-04-09 01:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078563002/20001

[commit-bot: I haz the power, 2015-04-09 03:47:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-09 03:48:04]

Patchset 2 (id:??) landed as
https://crrev.com/be79f477e4d1e66e2d80e7bcd5f9689f3fbbcefc
Cr-Commit-Position: refs/heads/master@{#324354}