src/heap/spaces.cc - Issue 1078533003: Relax heap size assert during compaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/spaces.cc

Issue 1078533003: Relax heap size assert during compaction (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/spaces.cc

diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc

index d372083a4a63aee1e48dbc4a18950a9ffa79e39e..e7807139a56e997882b1c8af1c804fd26962183b 100644

--- a/src/heap/spaces.cc

+++ b/src/heap/spaces.cc

@@ -1017,7 +1017,8 @@ Object* PagedSpace::FindObject(Address addr) {

bool PagedSpace::CanExpand() {

DCHECK(max_capacity_ % AreaSize() == 0);

- DCHECK(Capacity() <= heap()->MaxOldGenerationSize());

+ DCHECK(heap()->mark_compact_collector()->is_compacting() ||

+ Capacity() <= heap()->MaxOldGenerationSize());

DCHECK(heap()->CommittedOldGenerationMemory() <=

heap()->MaxOldGenerationSize() +

PagedSpace::MaxEmergencyMemoryAllocated());

« no previous file with comments | « no previous file | no next file » | no next file with comments »