Issue 10785002: Fix ARM build for gcc 4.2 on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10785002: Fix ARM build for gcc 4.2 on mac (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix ARM build for gcc 4.2 on mac

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/arm/simulator-arm.cc	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-16 15:06:06 UTC) #2

http://codereview.chromium.org/10785002/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/10785002/diff/1/src/arm/simulator-arm.cc#newco...
src/arm/simulator-arm.cc:3055: : static_cast<int>(val);
I don't think this change is correct, as it effectively ignores the
unsigned_integer bool. I think in the unsigned case you need to cast twice:
double -> uint32_t -> int, as in:

int temp = unsigned_integer
    ? static_cast<int>(static_cast<uint32_t>(val))
    : static_cast<int>(val);

Expand Messages | Collapse Messages