Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1078463003: Align ChannelLayout comments with kChannelOrderings values (Closed)

Created:
5 years, 8 months ago by wdzierzanowski
Modified:
5 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align ChannelLayout comments with kChannelOrderings values The documentation of several ChannelLayout enumerators was at odds with the values in kChannelOrderings. Committed: https://crrev.com/bf062c1169b111370d27b4ce7fec527bc3cc5d5d Cr-Commit-Position: refs/heads/master@{#324481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M media/base/channel_layout.h View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wdzierzanowski
PTAL dalecurtis. I'm assuming the values in kChannelOrderings are the ultimate source of truth, so ...
5 years, 8 months ago (2015-04-09 08:20:49 UTC) #2
DaleCurtis
lgtm, thanks for the cleanup!
5 years, 8 months ago (2015-04-09 16:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078463003/1
5 years, 8 months ago (2015-04-09 17:19:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 18:41:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 18:42:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf062c1169b111370d27b4ce7fec527bc3cc5d5d
Cr-Commit-Position: refs/heads/master@{#324481}

Powered by Google App Engine
This is Rietveld 408576698