Issue 10783038: Don't return private fields from imported libs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10783038: Don't return private fields from imported libs (Closed)

Created:
8 years, 5 months ago by hausner

Modified:
8 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't return private fields from imported libs Fix for issue 4098 (dartbug.com/4098) Committed: https://code.google.com/p/dart/source/detail?r=9722

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
M	runtime/vm/debugger.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View	1	5 chunks	+10 lines, -5 lines	0 comments	Download
M	tools/ddbg.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/10783038/diff/1/runtime/vm/debugger.h File runtime/vm/debugger.h (right): http://codereview.chromium.org/10783038/diff/1/runtime/vm/debugger.h#newcode325 runtime/vm/debugger.h:325: bool include_private_fields); Remove one space between bool and ...

8 years, 5 months ago (2012-07-17 21:04:54 UTC) #2

hausner

8 years, 2 months ago (2012-09-24 17:43:24 UTC) #3

I'm sure you were waiting anxiously for my response.

http://codereview.chromium.org/10783038/diff/1/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

http://codereview.chromium.org/10783038/diff/1/runtime/vm/debugger.h#newcode325
runtime/vm/debugger.h:325: bool  include_private_fields);
On 2012/07/17 21:04:54, srdjan wrote:
> Remove one space between bool and include...

Done.

Expand Messages | Collapse Messages

Issue 10783038: Don't return private fields from imported libs (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages