Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issue 1078213004: Remove --check-cloud-print-connector-policy (Closed)

Created:
5 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --check-cloud-print-connector-policy Current implementation of this check has no value. Browser refreshes policies only if it started without --check-cloud-print-connector-policy. In this case browser will enforce the policy from own side and disable service. BUG=327022 Committed: https://crrev.com/8c52aa421882f5366204a5d9573aefd047f96650 Cr-Commit-Position: refs/heads/master@{#325212}

Patch Set 1 #

Patch Set 2 : Fri Apr 10 18:45:00 PDT 2015 #

Patch Set 3 : Sat Apr 11 02:29:11 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -320 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +35 lines, -42 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 2 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 2 chunks +0 lines, -51 lines 0 comments Download
M chrome/service/service_process.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/service/service_process.cc View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Vitaly Buka (NO REVIEWS)
5 years, 8 months ago (2015-04-14 18:28:40 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 8 months ago (2015-04-14 18:33:01 UTC) #3
Vitaly Buka (NO REVIEWS)
+thestig for chrome/
5 years, 8 months ago (2015-04-14 18:57:12 UTC) #5
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-15 07:39:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078213004/40001
5 years, 8 months ago (2015-04-15 07:40:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-15 08:33:56 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 08:34:51 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c52aa421882f5366204a5d9573aefd047f96650
Cr-Commit-Position: refs/heads/master@{#325212}

Powered by Google App Engine
This is Rietveld 408576698