Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1078193002: Clear LayoutSVGText's frame rect if no line boxes are produced (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clear LayoutSVGText's frame rect if no line boxes are produced The frame rect is normally updated from SVGRootInlineBox::computePerCharacterLayoutInformation(), but if the children are empty, there'll be no such boxes and the frame rect won't be updated. BUG=474275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A LayoutTests/svg/text/text-bbox-of-empty-after-change.html View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 8 months ago (2015-04-10 18:11:45 UTC) #2
pdr.
lgtm
5 years, 8 months ago (2015-04-10 18:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078193002/1
5 years, 8 months ago (2015-04-10 18:13:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 18:23:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193559

Powered by Google App Engine
This is Rietveld 408576698