Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1078173002: Remove obsolete SharedTimer code in chromium (Closed)

Created:
5 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete SharedTimer code in chromium Blink no longer uses the SharedTimer, so we can remove the obsolete chromium support code. BUG=463143 Committed: https://crrev.com/662d7c313c3f2162515de6a8b77f89afb99113d8 Cr-Commit-Position: refs/heads/master@{#335485}

Patch Set 1 #

Patch Set 2 : Fix diffbase #

Patch Set 3 : Fixed test compile #

Patch Set 4 : Rebase #

Patch Set 5 : Removed unwanted change #

Patch Set 6 : Rebase #

Patch Set 7 : Fix test #

Patch Set 8 : Remove from html_viewer too #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -215 lines) Patch
M components/html_viewer/blink_platform_impl.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -15 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -45 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -17 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -74 lines 0 comments Download
M content/child/blink_platform_impl_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -57 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-10 15:50:21 UTC) #2
Sami
Yay, good riddance. lgtm!
5 years, 8 months ago (2015-04-10 16:18:11 UTC) #3
alex clarke (OOO till 29th)
Hi Jochen can I get an OWNERS review please?
5 years, 6 months ago (2015-06-09 09:36:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078173002/100001
5 years, 6 months ago (2015-06-09 09:58:03 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/45608)
5 years, 6 months ago (2015-06-09 10:11:11 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078173002/120001
5 years, 6 months ago (2015-06-09 10:15:13 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 12:18:37 UTC) #15
jochen (gone - plz use gerrit)
please also remove the code from components/html_viewer/blink_platform_impl.* lgtm
5 years, 6 months ago (2015-06-10 07:11:18 UTC) #16
alex clarke (OOO till 29th)
On 2015/06/10 07:11:18, jochen wrote: > please also remove the code from components/html_viewer/blink_platform_impl.* > > ...
5 years, 6 months ago (2015-06-10 11:22:43 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078173002/140001
5 years, 6 months ago (2015-06-10 11:23:28 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 12:17:44 UTC) #22
jochen (gone - plz use gerrit)
still lgtm, thx
5 years, 6 months ago (2015-06-11 12:46:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078173002/160001
5 years, 6 months ago (2015-06-22 09:54:20 UTC) #26
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 6 months ago (2015-06-22 10:56:23 UTC) #27
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 10:57:22 UTC) #28
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/662d7c313c3f2162515de6a8b77f89afb99113d8
Cr-Commit-Position: refs/heads/master@{#335485}

Powered by Google App Engine
This is Rietveld 408576698