Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1078133002: [iOS] Fix constness issue in side_swipe_gesture_recognizer (Closed)

Created:
5 years, 8 months ago by droger
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Fix constness issue in side_swipe_gesture_recognizer Committed: https://crrev.com/e67609cd84b41ffc49a74666fca69f5e033eb887 Cr-Commit-Position: refs/heads/master@{#326030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
droger
5 years, 8 months ago (2015-04-10 14:57:57 UTC) #2
jbbegue (google)
lgtm
5 years, 8 months ago (2015-04-10 17:43:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078133002/1
5 years, 8 months ago (2015-04-10 17:45:13 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-10 17:45:14 UTC) #8
droger
+pkl as jbbegue is not a committer yet.
5 years, 8 months ago (2015-04-15 14:03:08 UTC) #10
droger
-pkl (OOO) + sdefresne
5 years, 8 months ago (2015-04-21 13:28:53 UTC) #12
sdefresne
lgtm
5 years, 8 months ago (2015-04-21 14:06:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078133002/1
5 years, 8 months ago (2015-04-21 14:07:29 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 14:26:25 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 14:27:26 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e67609cd84b41ffc49a74666fca69f5e033eb887
Cr-Commit-Position: refs/heads/master@{#326030}

Powered by Google App Engine
This is Rietveld 408576698