Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 107813003: [arm] Use single instruction tail call sequence. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
6 years, 11 months ago
Reviewers:
ulan, Rodolph Perfetta
CC:
v8-dev
Visibility:
Public.

Description

[arm] Use single instruction tail call sequence. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18426

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove ASSERT on target. Add ASSERT on reloc mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Hey Ulan, This is an obvious optimization, since we do not need an interworking safe ...
7 years ago (2013-12-12 09:02:14 UTC) #1
ulan
lgtm https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc#newcode62 src/arm/macro-assembler-arm.cc:62: // 'target' is always generated ARM code, never ...
7 years ago (2013-12-12 09:42:16 UTC) #2
Rodolph Perfetta
https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc#newcode62 src/arm/macro-assembler-arm.cc:62: // 'target' is always generated ARM code, never THUMB ...
7 years ago (2013-12-12 09:50:29 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/107813003/diff/1/src/arm/macro-assembler-arm.cc#newcode62 src/arm/macro-assembler-arm.cc:62: // 'target' is always generated ARM code, never THUMB ...
7 years ago (2013-12-12 12:23:51 UTC) #4
Benedikt Meurer
6 years, 11 months ago (2014-01-02 06:11:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698