Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1078123002: Send resize event when the screen info changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index fe0203ff98f81e007b0d7e22aaa10b0bd7048e96..bb39189b6972df5a73170e9c4d65c5da03fc208c 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -170,7 +170,7 @@ RenderWidgetHostImpl::RenderWidgetHostImpl(RenderWidgetHostDelegate* delegate,
is_hidden_(hidden),
repaint_ack_pending_(false),
resize_ack_pending_(false),
- screen_info_out_of_date_(false),
+ screen_info_out_of_date_(true),
auto_resize_enabled_(false),
waiting_for_screen_rects_ack_(false),
needs_repainting_on_restore_(false),
@@ -580,9 +580,11 @@ bool RenderWidgetHostImpl::GetResizeParams(
ViewMsg_Resize_Params* resize_params) {
*resize_params = ViewMsg_Resize_Params();
- if (!screen_info_) {
+ const bool screen_info_was_out_of_date = screen_info_out_of_date_;
+ if (screen_info_out_of_date_) {
screen_info_.reset(new blink::WebScreenInfo);
GetWebScreenInfo(screen_info_.get());
+ screen_info_out_of_date_ = false;
}
no sievers 2015/04/10 18:40:31 Should we just move this out to WasResized()? And
mlamouri (slow - plz ping) 2015/04/13 11:39:08 Done.
resize_params->screen_info = *screen_info_;
resize_params->resizer_rect = GetRootWindowResizerRect();
@@ -603,7 +605,7 @@ bool RenderWidgetHostImpl::GetResizeParams(
(old_resize_params_->physical_backing_size.IsEmpty() &&
!resize_params->physical_backing_size.IsEmpty());
bool dirty =
- size_changed || screen_info_out_of_date_ ||
+ size_changed || screen_info_was_out_of_date ||
old_resize_params_->physical_backing_size !=
resize_params->physical_backing_size ||
old_resize_params_->is_fullscreen != resize_params->is_fullscreen ||
@@ -1135,7 +1137,6 @@ void RenderWidgetHostImpl::GetWebScreenInfo(blink::WebScreenInfo* result) {
else
RenderWidgetHostViewBase::GetDefaultScreenInfo(result);
latency_tracker_.set_device_scale_factor(result->deviceScaleFactor);
- screen_info_out_of_date_ = false;
}
const NativeWebKeyboardEvent*

Powered by Google App Engine
This is Rietveld 408576698