Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1078113002: Add serialization of SkBitmapSource's new filterQuality member variable (Closed)

Created:
5 years, 8 months ago by robertphillips
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add serialization of SkBitmapSource's new filterQuality member variable Missed this in https://codereview.chromium.org/1072603002/ (Add GM to repro crbug.com/472795) Committed: https://skia.googlesource.com/skia/+/25c40d25d75c8ee5d9632608ba09eb2c5fb765d2

Patch Set 1 #

Patch Set 2 : Added SKP version number comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M include/core/SkPicture.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 1 comment Download
M src/effects/SkBitmapSource.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
robertphillips
5 years, 8 months ago (2015-04-10 14:36:02 UTC) #3
reed1
lgtm
5 years, 8 months ago (2015-04-10 15:15:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078113002/20001
5 years, 8 months ago (2015-04-10 15:32:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/25c40d25d75c8ee5d9632608ba09eb2c5fb765d2
5 years, 8 months ago (2015-04-10 15:40:04 UTC) #7
mtklein
5 years, 8 months ago (2015-04-10 16:44:55 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1078113002/diff/20001/src/core/SkReadBuffer.h
File src/core/SkReadBuffer.h (right):

https://codereview.chromium.org/1078113002/diff/20001/src/core/SkReadBuffer.h...
src/core/SkReadBuffer.h:59: kBitmapourceFilterQuality_Version  = 41
(pelling)

Powered by Google App Engine
This is Rietveld 408576698