Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: src/parser.h

Issue 1078093002: Factor formal argument parsing into ParserBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/messages.js ('K') | « src/messages.js ('k') | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index e1cceaf34283d698f93614e60c04b1778bd5ae7d..67ab8f9058d38ac1e6daec4319a2dfa3544dd128 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -557,6 +557,8 @@ class ParserTraits {
typedef ObjectLiteral::Property* ObjectLiteralProperty;
typedef ZoneList<v8::internal::Expression*>* ExpressionList;
typedef ZoneList<ObjectLiteral::Property*>* PropertyList;
+ typedef const v8::internal::AstRawString* FormalParameter;
+ typedef ZoneList<const v8::internal::AstRawString*>* FormalParameterList;
typedef ZoneList<v8::internal::Statement*>* StatementList;
// For constructing objects returned by the traversing functions.
@@ -704,6 +706,10 @@ class ParserTraits {
static ZoneList<Expression*>* NullExpressionList() {
return NULL;
}
+ static const AstRawString* EmptyFormalParameter() { return NULL; }
+ static ZoneList<const AstRawString*>* NullFormalParameterList() {
+ return NULL;
+ }
// Non-NULL empty string.
V8_INLINE const AstRawString* EmptyIdentifierString();
@@ -739,6 +745,10 @@ class ParserTraits {
ZoneList<v8::internal::Statement*>* NewStatementList(int size, Zone* zone) {
return new(zone) ZoneList<v8::internal::Statement*>(size, zone);
}
+ ZoneList<const v8::internal::AstRawString*>* NewFormalParameterList(
+ int size, Zone* zone) {
+ return new (zone) ZoneList<const v8::internal::AstRawString*>(size, zone);
+ }
V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type,
FunctionKind kind = kNormalFunction);
« src/messages.js ('K') | « src/messages.js ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698