Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1078073002: Add more exhaustive tests for Math.min and Math.max. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add more exhaustive tests for Math.min and Math.max. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/dee044d601cd77433bb7689ceb0ac12b4edfc9bc Cr-Commit-Position: refs/heads/master@{#27747}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -18 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/result-table-max.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/result-table-min.js View 1 chunk +105 lines, -0 lines 0 comments Download
M tools/compare-table-gen.js View 8 chunks +30 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-10 11:44:45 UTC) #1
titzer
5 years, 8 months ago (2015-04-10 11:49:23 UTC) #2
Michael Starzinger
LGTM with one comment. https://codereview.chromium.org/1078073002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1078073002/diff/1/test/mjsunit/mjsunit.status#newcode131 test/mjsunit/mjsunit.status:131: 'mjsunit/result-table-min': [PASS, NO_VARIANTS], Let's drop ...
5 years, 8 months ago (2015-04-10 11:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078073002/20001
5 years, 8 months ago (2015-04-10 11:55:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 12:35:16 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 12:35:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dee044d601cd77433bb7689ceb0ac12b4edfc9bc
Cr-Commit-Position: refs/heads/master@{#27747}

Powered by Google App Engine
This is Rietveld 408576698