Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1077963006: Revert of Delete session cookies immediately after loading the cookie DB. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@migrate_to_v9
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete session cookies immediately after loading the cookie DB. (patchset #4 id:120001 of https://codereview.chromium.org/1097593002/) Reason for revert: This CL broke the Win7 Tests (dbg)(1) bot. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37364 Original issue's description: > Delete session cookies immediately after loading the cookie DB. > > Previously, the session cookies were deleted after all cookies were loaded into > memory. This allows for a race condition where new session cookies are inserted > into the database while the cookies are being loaded into memory, which causes > the new session cookies to also be deleted. > > BUG= > > Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843 > Cr-Commit-Position: refs/heads/master@{#326672} TBR=erikwright@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8c6775990e9b343d133b2f1560f4d45be445426c Cr-Commit-Position: refs/heads/master@{#326694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -89 lines) Patch
M content/browser/net/sqlite_persistent_cookie_store.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 2 chunks +0 lines, -85 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of Delete session cookies immediately after loading the cookie DB.
5 years, 8 months ago (2015-04-23 23:56:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077963006/1
5 years, 8 months ago (2015-04-23 23:57:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 23:58:22 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 23:59:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c6775990e9b343d133b2f1560f4d45be445426c
Cr-Commit-Position: refs/heads/master@{#326694}

Powered by Google App Engine
This is Rietveld 408576698