Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1077963002: Revert of [Media Router] Design MediaRouter interface with stub implementation. (Closed)

Created:
5 years, 8 months ago by Sorin Jianu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Design MediaRouter interface with stub implementation. (patchset #27 id:590001 of https://codereview.chromium.org/1020743003/) Reason for revert: Suspecting it breaks building unit_tests_main on Mac GN and Win8 GN http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6186 FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests_main.exe /PDB:unit_tests_main.exe.pdb @unit_tests_main.exe.rsp browser.browser_ppapi_host_impl.obj : error LNK2019: unresolved external symbol "public: __thiscall ppapi::host::PpapiHost::PpapiHost(class IPC::Sender *,class ppapi::PpapiPermissions const &)" (??0PpapiHost@host@ppapi@@QAE@PAVSender@IPC@@ABVPpapiPermissions@2@@Z) referenced in function "public: __thiscall content::BrowserPpapiHostImpl::BrowserPpapiHostImpl(class IPC::Sender *,class ppapi::PpapiPermissions const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class base::FilePath const &,bool,bool)" (??0BrowserPpapiHostImpl@content@@QAE@PAVSender@IPC@@ABVPpapiPermissions@ppapi@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@3_N4@Z) browser.browser_ppapi_host_impl.obj : error LNK2019: unresolved external symbol "public: void __thiscall ppapi::host::PpapiHost::AddHostFactoryFilter(class scoped_ptr<class ppapi::host::HostFactory,struct base::DefaultDeleter<class ppapi::host::HostFactory> >)" (?AddHostFactoryFilter@PpapiHost@host@ppapi@@QAEXV?$scoped_ptr@VHostFactory@host@ppapi@@U?$DefaultDeleter@VHostFactory@host@ppapi@@@base@@@@@Z) referenced in function "public: __thiscall content::BrowserPpapiHostImpl::BrowserPpapiHostImpl(class IPC::Sender *,class ppapi::PpapiPermissions const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class base::FilePath const &,bool,bool)" (??0BrowserPpapiHostImpl@content@@QAE@PAVSender@IPC@@ABVPpapiPermissions@ppapi@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@3_N4@Z) browser.pepper_tcp_socket_message_filter.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z) browser.pepper_truetype_font_list_host.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z) browser.pepper_udp_socket_message_filter.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z) ======================= FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Wl,-search_paths_first -L. -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o ./unit_tests_main -Wl,-filelist,./unit_tests_main.rsp ./libffmpegsumo.dylib -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security -framework QuartzCore -framework SystemConfiguration -lresolv -framework Accelerate -framework AudioUnit -framework CoreVideo -framework Cocoa -framework IOSurface -framework OpenGL -framework CoreMIDI -framework QTKit -framework AudioToolbox -framework CoreAudio -lbsm -framework IOBluetooth Undefined symbols for architecture x86_64: "SuddenMotionSensor::ReadSensorValues(float*)", referenced from: (anonymous namespace)::FetchOrientation(SuddenMotionSensor*, content::SharedMemorySeqLockBuffer<blink::WebDeviceOrientationData>*) in browser.data_fetcher_shared_memory_mac.o (anonymous namespace)::FetchMotion(SuddenMotionSensor*, content::SharedMemorySeqLockBuffer<blink::WebDeviceMotionData>*) in browser.data_fetcher_shared_memory_mac.o "SuddenMotionSensor::Create()", referenced from: content::DataFetcherSharedMemory::Start(content::ConsumerType, void*) in browser.data_fetcher_shared_memory_mac.o "SuddenMotionSensor::~SuddenMotionSensor()", referenced from: base::DefaultDeleter<SuddenMotionSensor>::operator()(SuddenMotionSensor*) const in browser.data_fetcher_shared_memory_mac.o "aura::WindowEventDispatcher::HoldPointerMoves()", referenced from: content::CompositorResizeLock::CompositorResizeLock(aura::WindowTreeHost*, gfx::Size, bool, base::TimeDelta const&) in browser.compositor_resize_lock_aura.o "aura::WindowEventDispatcher::ReleasePointerMoves()", referenced from: content::CompositorResizeLock::CancelLock() in browser.compositor_resize_lock_aura.o "blink::OpenTypeVerticalData::OpenTypeVerticalData(blink::FontPlatformData const&)", referenced from: blink::OpenTypeVerticalData::create(blink::FontPlatformData const&) in blink_platform.FontCache.o Original issue's description: > [Media Router] MediaRouter interfaces with stub implementations. > > - Updated Media Router data classes. > - Added MediaRouteResponse class. > - Added MediaRouteProviderManagerHost interface. > - Added MediaRouter interface with a stub MediaRouterImpl class. > - MRImpl are is a KeyedService and is instantiated via > its BrowserContextKeyedServiceFactory implementation. > - Added MediaRoutesObserver / MediaSinksObserver interfaces which are > used by MediaRouter API. > > BUG=461815, 464199 > > Committed: https://crrev.com/45aa4cbbb775de85003187a8b1371d7922dc0194 > Cr-Commit-Position: refs/heads/master@{#324541} TBR=kmarshall@chromium.org,mfoltz@chromium.org,imcheng@chromium.org,xhwang@chromium.org,marshallk@google.com,imcheng@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461815, 464199 Committed: https://crrev.com/5d6b8901b921b70dccd445ba5cabfaf99c3f6414 Cr-Commit-Position: refs/heads/master@{#324557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -553 lines) Patch
M chrome/browser/media/router/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/media/router/media_route.h View 3 chunks +11 lines, -6 lines 0 comments Download
D chrome/browser/media/router/media_router.h View 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/media/router/media_router_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/media/router/media_router_impl.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/media/router/media_router_impl_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/media/router/media_router_impl_factory.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/media/router/media_routes_observer.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/media/router/media_routes_observer.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/media/router/media_sink.h View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/media/router/media_sink.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/media/router/media_sink_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/media/router/media_sinks_observer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/media/router/media_sinks_observer.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/media/router/media_source.h View 1 chunk +3 lines, -25 lines 0 comments Download
M chrome/browser/media/router/media_source.cc View 1 chunk +3 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sorin Jianu
Created Revert of [Media Router] Design MediaRouter interface with stub implementation.
5 years, 8 months ago (2015-04-10 01:04:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077963002/1
5 years, 8 months ago (2015-04-10 01:05:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 01:12:03 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 01:12:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d6b8901b921b70dccd445ba5cabfaf99c3f6414
Cr-Commit-Position: refs/heads/master@{#324557}

Powered by Google App Engine
This is Rietveld 408576698