Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 1077823005: Declare providing extension capabilities in the manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
index ba1f7570f6f07b09fa0b0f524044da0dde6f7e58..fc3fca6ceed61a8c8ed70977743fb7a28ab61243 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
@@ -491,8 +491,19 @@ FileManagerPrivateGetProvidingExtensionsFunction::Run() {
new ProvidingExtension);
providing_extension->extension_id = info.extension_id;
providing_extension->name = info.name;
- providing_extension->can_configure = info.can_configure;
- providing_extension->can_add = info.can_add;
+ providing_extension->configurable = info.capabilities.configurable();
+ providing_extension->multiple_mounts = info.capabilities.multiple_mounts();
+ switch (info.capabilities.source()) {
not at google - send to devlin 2015/04/24 17:49:30 providing_extension->source and info.capabilities.
mtomasz 2015/05/07 03:33:59 They are not the same. I convert the generated typ
+ case SOURCE_FILE:
+ providing_extension->source = api::file_system_provider::SOURCE_FILE;
+ break;
+ case SOURCE_DEVICE:
+ providing_extension->source = api::file_system_provider::SOURCE_DEVICE;
+ break;
+ case SOURCE_NETWORK:
+ providing_extension->source = api::file_system_provider::SOURCE_NETWORK;
+ break;
+ }
providing_extensions.push_back(providing_extension);
}
@@ -538,7 +549,6 @@ FileManagerPrivateConfigureProvidedFileSystemFunction::Run() {
using file_manager::Volume;
VolumeManager* const volume_manager =
VolumeManager::Get(chrome_details_.GetProfile());
- LOG(ERROR) << "LOOKING FOR: " << params->volume_id;
base::WeakPtr<Volume> volume =
volume_manager->FindVolumeById(params->volume_id);
if (!volume.get())

Powered by Google App Engine
This is Rietveld 408576698