Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/build.py

Issue 1077823002: Adds a simarmv5te build and test target. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/tests/vm/vm.status ('K') | « third_party/pkg_tested/pkg_tested.status ('k') | tools/gyp/configurations.gypi » ('j') | tools/testing/dart/runtime_configuration.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
===================================================================
--- tools/build.py (revision 45017)
+++ tools/build.py (working copy)
@@ -55,7 +55,7 @@
default=False, action="store_true")
result.add_option("-a", "--arch",
help='Target architectures (comma-separated).',
- metavar='[all,ia32,x64,simarm,arm,armv5te,simmips,mips,simarm64,arm64,]',
+ metavar='[all,ia32,x64,simarm,arm,simarmv5te,armv5te,simmips,mips,simarm64,arm64,]',
ricow1 2015/04/10 08:23:41 long line
zra 2015/04/10 16:07:20 Done.
default=utils.GuessArchitecture())
result.add_option("--os",
help='Target OSs (comma-separated).',
@@ -105,8 +105,8 @@
print "Unknown mode %s" % mode
return False
for arch in options.arch:
- archs = ['ia32', 'x64', 'simarm', 'arm', 'armv5te', 'simmips', 'mips',
- 'simarm64', 'arm64',]
+ archs = ['ia32', 'x64', 'simarm', 'arm', 'simarmv5te', 'armv5te', 'simmips',
+ 'mips', 'simarm64', 'arm64',]
ricow1 2015/04/10 08:23:41 I would indent this one less space
zra 2015/04/10 16:07:20 Done.
if not arch in archs:
print "Unknown arch %s" % arch
return False
« runtime/tests/vm/vm.status ('K') | « third_party/pkg_tested/pkg_tested.status ('k') | tools/gyp/configurations.gypi » ('j') | tools/testing/dart/runtime_configuration.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698