Issue 1077773002: Merge to XFA: Fix ref to timezone variable - removed in VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077773002: Merge to XFA: Fix ref to timezone variable - removed in VS 2015 (Closed)

Created:
5 years, 8 months ago by brucedawson

Modified:
5 years, 8 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix ref to timezone variable - removed in VS 2015 It turns out that 'timezone' has been deprecated for a while. If deprecation messages are enabled then VS 2013 says this when 'timezone' is referenced: warning C4996: 'timezone': This function or variable may be unsafe. Consider using _get_timezone instead. Sometimes features stay deprecated for decades, but in this case 'timezone' is now gone. Merged from change https://codereview.chromium.org/1075673002 TBR=tsepez@chromium.org BUG=440500 Committed: https://pdfium.googlesource.com/pdfium/+/06e015f33248e4453259c8cebc414e9601638a6d

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

brucedawson

5 years, 8 months ago (2015-04-09 18:10:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
06e015f33248e4453259c8cebc414e9601638a6d (presubmit successful).