Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1077633002: [release-tools] Make chromium roll more robust after failing rolls. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release-tools] Make chromium roll more robust after failing rolls. Always use the same branch name (the old version leaked branches). Always try to delete a possibly existing branch on start-up and also clean up in the end. NOTRY=true TBR=tandrii@chromium.org Committed: https://crrev.com/ec0329e2d6a7444b5280b2c3ac77b65f2be91129 Cr-Commit-Position: refs/heads/master@{#27722}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M tools/release/chromium_roll.py View 4 chunks +12 lines, -27 lines 1 comment Download
M tools/release/test_scripts.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1077633002/diff/1/tools/release/chromium_roll.py File tools/release/chromium_roll.py (left): https://codereview.chromium.org/1077633002/diff/1/tools/release/chromium_roll.py#oldcode48 tools/release/chromium_roll.py:48: self["v8_path"] = os.getcwd() Really all commands have a ...
5 years, 8 months ago (2015-04-09 12:38:58 UTC) #2
tandrii(chromium)
lgtm
5 years, 8 months ago (2015-04-09 13:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077633002/1
5 years, 8 months ago (2015-04-09 21:36:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 21:37:40 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 21:37:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec0329e2d6a7444b5280b2c3ac77b65f2be91129
Cr-Commit-Position: refs/heads/master@{#27722}

Powered by Google App Engine
This is Rietveld 408576698