Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1077553002: jinja2: make templates outside of // work again (Closed)

Created:
5 years, 8 months ago by tsniatowski
Modified:
5 years, 8 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jinja2: make templates outside of // work again A recent CL -- http://crrev.com/1002313002 -- made the jinja wrapper script barf on templates located outside CHROMIUM_SRC (the used Jinja2 loader disallows template paths with '..' components). While not actively used currently in the Chromium build, it is a somewhat useful feature of the wrapper that used to work. Fix by instatiating the jinja template loader with a configurable path as the search directory, rather than a hardcoded CHROMIUM_SRC. Usages with templates outside CHROMIUM_SRC now must pass an appropriate --loader-base-dir value to the wrapper script. R=cjhopman,jbudorick BUG= Committed: https://crrev.com/65b1b8d1d29b68df077dfaec40d3fd4e8961758e Cr-Commit-Position: refs/heads/master@{#324597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M build/android/gyp/jinja_template.py View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tsniatowski
5 years, 8 months ago (2015-04-09 08:20:46 UTC) #1
newt (away)
lgtm
5 years, 8 months ago (2015-04-09 20:59:55 UTC) #3
cjhopman
lgtm
5 years, 8 months ago (2015-04-09 21:29:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077553002/1
5 years, 8 months ago (2015-04-10 04:51:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 06:45:27 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65b1b8d1d29b68df077dfaec40d3fd4e8961758e Cr-Commit-Position: refs/heads/master@{#324597}
5 years, 8 months ago (2015-04-10 06:46:19 UTC) #8
tsniatowski
5 years, 8 months ago (2015-04-10 06:58:17 UTC) #9
Message was sent while issue was closed.
Thanks :)

Powered by Google App Engine
This is Rietveld 408576698