Stop rendering text inside flex boxes.

Stop rendering text inside flex boxes.

Text can only only inside paragraphs and inlines. This patch makes it
so we stop putting such text nodes in the render tree at all if their
parent is not a paragraph or an inline.

This is the final step in making it so that we don't create anonymous
renderers, which fixes a crash in the new custom layout code.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1ea0e439342f8764af422ab6f02d9431844b606c

[ojan, 2015-04-09 02:07:34]

ojan@chromium.org changed reviewers:
+ eseidel@chromium.org, ianh@google.com

[eseidel, 2015-04-09 05:19:56]

This change is going to need to be announced.  I think we should seriously
consider adding a <p> tag with display: paragraph default.

https://codereview.chromium.org/1077473002/diff/1/sky/tests/clipping/backgrou...
File sky/tests/clipping/background-opaque-clipped-gradients.sky (right):

https://codereview.chromium.org/1077473002/diff/1/sky/tests/clipping/backgrou...
sky/tests/clipping/background-opaque-clipped-gradients.sky:15: <p
style="display: paragraph">Test passes if the image below shows nested green,
blue and yellow squares with a dotted black border.</p>
I think we should consider having a built-in p tag for connivence.

https://codereview.chromium.org/1077473002/diff/1/sky/tests/clipping/backgrou...
sky/tests/clipping/background-opaque-clipped-gradients.sky:15: <p
style="display: paragraph">Test passes if the image below shows nested green,
blue and yellow squares with a dotted black border.</p>
I think we should consider having a built-in p tag for convenience.

https://codereview.chromium.org/1077473002/diff/1/sky/tests/layout/custom-dir...
File sky/tests/layout/custom-dirty-bits.sky (right):

https://codereview.chromium.org/1077473002/diff/1/sky/tests/layout/custom-dir...
sky/tests/layout/custom-dirty-bits.sky:14:
document.querySelector('block').setLayoutManager(() => {});
So this is saying that custom layout can't layout text.  Which I guess is fine. 
Just not immediately expected. :)

[eseidel, 2015-04-09 05:20:03]

lgtm

[ojan, 2015-04-09 18:32:53]

On 2015/04/09 at 05:19:56, eseidel wrote:
> This change is going to need to be announced. 

Yup.

> I think we should seriously consider adding a <p> tag with display: paragraph
default.

Yeah. I waffled on this. It's a slippery slope adding defaults like this. But,
I'll go ahead and do so.

>
https://codereview.chromium.org/1077473002/diff/1/sky/tests/layout/custom-dir...
> File sky/tests/layout/custom-dirty-bits.sky (right):
> 
>
https://codereview.chromium.org/1077473002/diff/1/sky/tests/layout/custom-dir...
> sky/tests/layout/custom-dirty-bits.sky:14:
document.querySelector('block').setLayoutManager(() => {});
> So this is saying that custom layout can't layout text.  Which I guess is
fine.  Just not immediately expected. :)

Yup. We should do line layout eventually, but we'll need a very different API
for it.

[ojan, 2015-04-09 18:40:07]

Committed patchset #2 (id:20001) manually as
1ea0e439342f8764af422ab6f02d9431844b606c (presubmit successful).