Remove PrerenderLocalPredictor, part 1.

Remove PrerenderLocalPredictor, part 1.

After https://codereview.chromium.org/1048723003/, it's dead code. This removes
PrerenderLocalPredictor and the code in chrome/browser/prerender. Follow-up CLs
will remove the LoggedInPredictor, side-effect free SafeBrowsing whitelist, the
prefetch IPC, and history::BriefVisitInfo.

Also tidies up histograms.xml to obsolete some enums that didn't get obsoleted
before.

BUG=471807
Committed: https://crrev.com/a978e28d783215e2ad78618636b9b7bb5b888bb0
Cr-Commit-Position: refs/heads/master@{#325673}

[davidben, 2015-04-08 21:27:18]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2015-04-08 21:27:18]

Enjoy!

[davidben, 2015-04-08 21:30:42]

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_field_trial.h (right):

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_field_trial.h:26: bool
IsSideEffectFreeWhitelistEnabled();
(This function is called elsewhere and will be removed in the next CL, along
with its caller.)

[mmenke, 2015-04-08 21:31:06]

On 2015/04/08 21:27:18, David Benjamin wrote:
> Enjoy!

2000 lines of production code...And 1 test with 80 lines of code, that just
checks preferences?  Hrm...

[mmenke, 2015-04-09 16:29:05]

Going to take me a while to feel comfortable signing off on this one.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:15: #include
"base/memory/weak_ptr.h"
Not needed (In header)

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:17: #include
"base/prefs/pref_service.h"
Not needed?  (Actually wasn't needed before, either, I think)

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:18: #include
"base/strings/utf_string_conversions.h"
Is this used anywhere?

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:26: #include
"chrome/browser/predictors/predictor_database_factory.h"
I don't think we need these three any more.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:43: #include
"chrome/common/prerender_messages.h"
Don't think this has been used in this file for a while.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:61: #include
"net/url_request/url_request_context_getter.h"
I don't think we need these two any more.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_tab_helper.cc (right):

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_tab_helper.cc:10: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
No longer needed.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_tab_helper.cc:15: #include
"components/password_manager/core/browser/password_manager.h"
No longer needed.

[davidben, 2015-04-09 20:43:00]

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:15: #include
"base/memory/weak_ptr.h"
On 2015/04/09 16:29:05, mmenke wrote:
> Not needed (In header)

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:17: #include
"base/prefs/pref_service.h"
On 2015/04/09 16:29:05, mmenke wrote:
> Not needed?  (Actually wasn't needed before, either, I think)

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:18: #include
"base/strings/utf_string_conversions.h"
On 2015/04/09 16:29:05, mmenke wrote:
> Is this used anywhere?

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:26: #include
"chrome/browser/predictors/predictor_database_factory.h"
On 2015/04/09 16:29:04, mmenke wrote:
> I don't think we need these three any more.

Looks like prediction_options is still used. Other two are gone.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:43: #include
"chrome/common/prerender_messages.h"
On 2015/04/09 16:29:05, mmenke wrote:
> Don't think this has been used in this file for a while.

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:61: #include
"net/url_request/url_request_context_getter.h"
On 2015/04/09 16:29:05, mmenke wrote:
> I don't think we need these two any more.

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_tab_helper.cc (right):

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_tab_helper.cc:10: #include
"chrome/browser/password_manager/chrome_password_manager_client.h"
On 2015/04/09 16:29:05, mmenke wrote:
> No longer needed.

Done.

https://codereview.chromium.org/1077433002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_tab_helper.cc:15: #include
"components/password_manager/core/browser/password_manager.h"
On 2015/04/09 16:29:05, mmenke wrote:
> No longer needed.

Done.

[mmenke, 2015-04-10 16:42:05]

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.cc:18: const std::string
switch_value =
#include <string> (As you just removed it from the header...)

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.cc:59:
DCHECK_EQ(switches::kPrerenderFromOmniboxSwitchValueAuto, switch_value);
Still need base/logging.h

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_local_predictor.cc (left):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:189: base::Time::Now() -
start_time_);
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:221:
db->GetBriefVisitInfoOfMostRecentVisits(max_visits_, visit_history_.get());
This class is the only consumer of this method.  Remove it, too?

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:221:
db->GetBriefVisitInfoOfMostRecentVisits(max_visits_, visit_history_.get());
In fact, I think this is the only reason BriefVisitInfo even exists?  Rip it all
out?  Fine to do in another CL.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:546:
IDR_PRERENDER_URL_WHITELIST);
Also remove this resource (File and GRD entry)?  Looks to be empty, anyways.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:605:
"Prerender.LocalPredictorTimeUntilUsed",
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1025: base::Time::Now() -
info->start_time_);
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1155: 100);
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1170:
UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingBaselinePLT",
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1181:
UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingPLT",
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1200:
UMA_HISTOGRAM_ENUMERATION("Prerender.LocalPredictorEvent",
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1259: base::Time::Now() -
info->start_time_);
Obsolete UMA

https://codereview.chromium.org/1077433002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1077433002/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:1: # Copyright 2012 The Chromium Authors. All rights
reserved.
Picking a random file to put this comment in.  You should also remove the
(currently unused...) switch "kDisablePrerenderLocalPredictor"

[davidben, 2015-04-13 15:51:15]

(Also pruned a lot of now obsolete enums since apparently those are obsoletable
too?)

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.cc:18: const std::string
switch_value =
On 2015/04/10 16:42:04, mmenke wrote:
> #include <string> (As you just removed it from the header...)

Done. (We really should have have a tool for this or something...)

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.cc:59:
DCHECK_EQ(switches::kPrerenderFromOmniboxSwitchValueAuto, switch_value);
On 2015/04/10 16:42:04, mmenke wrote:
> Still need base/logging.h

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_local_predictor.cc (left):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:189: base::Time::Now() -
start_time_);
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done. (Also seems worth having tooling, though I should haven't remembered
this.)

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:221:
db->GetBriefVisitInfoOfMostRecentVisits(max_visits_, visit_history_.get());
On 2015/04/10 16:42:04, mmenke wrote:
> This class is the only consumer of this method.  Remove it, too?

Good catch. I'll do that in a follow-up.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:546:
IDR_PRERENDER_URL_WHITELIST);
On 2015/04/10 16:42:04, mmenke wrote:
> Also remove this resource (File and GRD entry)?  Looks to be empty, anyways.

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:605:
"Prerender.LocalPredictorTimeUntilUsed",
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1025: base::Time::Now() -
info->start_time_);
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1155: 100);
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1170:
UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingBaselinePLT",
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1181:
UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingPLT",
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1200:
UMA_HISTOGRAM_ENUMERATION("Prerender.LocalPredictorEvent",
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:1259: base::Time::Now() -
info->start_time_);
On 2015/04/10 16:42:04, mmenke wrote:
> Obsolete UMA

Done.

https://codereview.chromium.org/1077433002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1077433002/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:1: # Copyright 2012 The Chromium Authors. All rights
reserved.
On 2015/04/10 16:42:04, mmenke wrote:
> Picking a random file to put this comment in.  You should also remove the
> (currently unused...) switch "kDisablePrerenderLocalPredictor"

Done.

[mmenke, 2015-04-13 16:02:42]

LGTM

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.cc:18: const std::string
switch_value =
On 2015/04/13 15:51:14, David Benjamin wrote:
> On 2015/04/10 16:42:04, mmenke wrote:
> > #include <string> (As you just removed it from the header...)
> 
> Done. (We really should have have a tool for this or something...)

But then I'd have nothing to whine about on CLs!  What would I go with my time?

[davidben, 2015-04-13 16:33:22]

davidben@chromium.org changed reviewers:
+ asvitkine@chromium.org, felt@chromium.org, jhawkins@chromium.org

[davidben, 2015-04-13 16:33:23]

+asvitkine for histograms.xml
+felt for chrome/browser/extensions/activity_log/
+jhawkins for:
  chrome/browser/browser_resources.grd
  chrome/browser/resources/prerender_url_whitelist.dat
  chrome/browser/ui/browser_navigator.cc

[davidben, 2015-04-13 16:40:01]

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_local_predictor.cc (left):

https://codereview.chromium.org/1077433002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_local_predictor.cc:221:
db->GetBriefVisitInfoOfMostRecentVisits(max_visits_, visit_history_.get());
On 2015/04/13 15:51:14, David Benjamin wrote:
> On 2015/04/10 16:42:04, mmenke wrote:
> > This class is the only consumer of this method.  Remove it, too?
> 
> Good catch. I'll do that in a follow-up.

(For posterity, here's that follow-up.
https://codereview.chromium.org/1081923002/ )

[Alexei Svitkine (slow), 2015-04-13 16:43:06]

lgtm

[davidben, 2015-04-16 15:37:28]

On 2015/04/13 16:43:06, Alexei Svitkine wrote:
> lgtm

felt/jhawkins: friendly ping for OWNERS stamps. (This should be fairly small.
mmenke already reviewed the big scary bits.)

---

+felt for chrome/browser/extensions/activity_log/
+jhawkins for:
  chrome/browser/browser_resources.grd
  chrome/browser/resources/prerender_url_whitelist.dat
  chrome/browser/ui/browser_navigator.cc

[James Hawkins, 2015-04-16 15:40:12]

lgtm

[felt, 2015-04-17 16:59:40]

lgtm

[davidben, 2015-04-17 17:04:33]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-04-17 17:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from felt@chromium.org,
asvitkine@chromium.org, jhawkins@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1077433002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-17 17:06:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1077433002/60001

[commit-bot: I haz the power, 2015-04-17 18:09:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-17 18:10:52]

Patchset 4 (id:??) landed as
https://crrev.com/a978e28d783215e2ad78618636b9b7bb5b888bb0
Cr-Commit-Position: refs/heads/master@{#325673}