Issue 107743002: Add 'Dump Database' tab to syncfs-internals (only for v2 for now)

Issue 107743002: Add 'Dump Database' tab to syncfs-internals (only for v2 for now) (Closed)

Created:
7 years ago by kinuko

Modified:
7 years ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add 'Dump Database' tab to syncfs-internals (only for v2 for now) Screenshot: https://drive.google.com/a/google.com/file/d/0B6X0ebzoaRahOEFxVVVrZFMzMnc/view BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239200

Patch Set 4 : regular -> Regular, added app_id #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+337 lines, -14 lines)			Patch
A	chrome/browser/resources/sync_file_system_internals/dump_database.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/sync_file_system_internals/dump_database.js	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/sync_file_system_internals/main.html	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/sync_file_system_internals_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database.cc	View	1 2 3	4 chunks	+121 lines, -12 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/mock_remote_file_sync_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/mock_remote_file_sync_service.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/remote_file_sync_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service.h	View		4 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service_factory.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/sync_file_system_internals/dump_database_handler.h	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/sync_file_system_internals/dump_database_handler.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

A bit rough patch, but something like this could be probably useful?

7 years ago (2013-12-06 06:57:10 UTC) #1

tzik

lgtm https://codereview.chromium.org/107743002/diff/10023/chrome/browser/sync_file_system/drive_backend/metadata_database.cc File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right): https://codereview.chromium.org/107743002/diff/10023/chrome/browser/sync_file_system/drive_backend/metadata_database.cc#newcode1840 chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1840: "regular"); s/regular/Regular/?

7 years ago (2013-12-06 07:05:52 UTC) #2

kinuko

Updated, also added app_id. https://codereview.chromium.org/107743002/diff/10023/chrome/browser/sync_file_system/drive_backend/metadata_database.cc File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right): https://codereview.chromium.org/107743002/diff/10023/chrome/browser/sync_file_system/drive_backend/metadata_database.cc#newcode1840 chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1840: "regular"); On 2013/12/06 07:05:52, tzik ...

7 years ago (2013-12-06 07:26:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/107743002/50001

7 years ago (2013-12-06 07:26:56 UTC) #5

Message was sent while issue was closed.

Change committed as 239200

Expand Messages | Collapse Messages