Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1077343002: [turbofan] Optimize loads of global constants in JSTypedLowering. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize loads of global constants in JSTypedLowering. R=mstarzinger@chromium.org,verwaest@chromium.org BUG= Committed: https://crrev.com/069e6b2f5fc5b6cb8d31197d6e0c2c86190f18fa Cr-Commit-Position: refs/heads/master@{#27792}

Patch Set 1 #

Patch Set 2 : Added unittests #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+915 lines, -16 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/types.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/global-infinity.js View 1 chunk +127 lines, -0 lines 0 comments Download
A test/mjsunit/global-infinity-strict.js View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
A test/mjsunit/global-nan.js View 1 chunk +127 lines, -0 lines 0 comments Download
A test/mjsunit/global-nan-strict.js View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
A test/mjsunit/global-undefined.js View 1 chunk +149 lines, -0 lines 0 comments Download
A test/mjsunit/global-undefined-strict.js View 1 chunk +163 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
titzer
5 years, 8 months ago (2015-04-13 08:17:03 UTC) #1
titzer
On 2015/04/13 08:17:03, titzer wrote: I should add some unit tests for JSTypedLowering...
5 years, 8 months ago (2015-04-13 09:04:09 UTC) #2
titzer
On 2015/04/13 09:04:09, titzer wrote: > On 2015/04/13 08:17:03, titzer wrote: > > I should ...
5 years, 8 months ago (2015-04-13 12:49:42 UTC) #3
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/1077343002/diff/20001/test/mjsunit/global-infinity-strict.js File test/mjsunit/global-infinity-strict.js (right): https://codereview.chromium.org/1077343002/diff/20001/test/mjsunit/global-infinity-strict.js#newcode4 test/mjsunit/global-infinity-strict.js:4: "use strict"; nit: After the flags ...
5 years, 8 months ago (2015-04-13 15:04:29 UTC) #4
titzer
https://codereview.chromium.org/1077343002/diff/20001/test/mjsunit/global-infinity-strict.js File test/mjsunit/global-infinity-strict.js (right): https://codereview.chromium.org/1077343002/diff/20001/test/mjsunit/global-infinity-strict.js#newcode4 test/mjsunit/global-infinity-strict.js:4: "use strict"; On 2015/04/13 15:04:29, Michael Starzinger wrote: > ...
5 years, 8 months ago (2015-04-13 15:23:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077343002/40001
5 years, 8 months ago (2015-04-13 15:23:56 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-13 16:22:16 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 16:22:23 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/069e6b2f5fc5b6cb8d31197d6e0c2c86190f18fa
Cr-Commit-Position: refs/heads/master@{#27792}

Powered by Google App Engine
This is Rietveld 408576698