Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/dom/src/dart2js_CssClassSet.dart

Issue 1077203004: Enforce token syntax for CssClassSet arguments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix --checked contains test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/src/CssClassSet.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/dart2js_CssClassSet.dart
diff --git a/tools/dom/src/dart2js_CssClassSet.dart b/tools/dom/src/dart2js_CssClassSet.dart
index 783828b6a3876fee38b8d3a4a06382d8491d9c67..cf5fa33660748dc256431f16a4a2704dcf39ccc8 100644
--- a/tools/dom/src/dart2js_CssClassSet.dart
+++ b/tools/dom/src/dart2js_CssClassSet.dart
@@ -100,7 +100,7 @@ class _ElementCssClassSet extends CssClassSetImpl {
_element.className = '';
}
- bool contains(String value) {
+ bool contains(Object value) {
return _contains(_element, value);
}
@@ -136,8 +136,8 @@ class _ElementCssClassSet extends CssClassSetImpl {
_removeWhere(_element, test, false);
}
- static bool _contains(Element _element, String value) {
- return _classListContains(_classListOf(_element), value);
+ static bool _contains(Element _element, Object value) {
+ return value is String && _classListContains(_classListOf(_element), value);
}
static bool _add(Element _element, String value) {
« no previous file with comments | « tools/dom/src/CssClassSet.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698