Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1077153004: Reland: Fix logic for incremental marking steps on tenured allocation (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: Fix logic for incremental marking steps on tenured allocation BUG= Committed: https://crrev.com/5000650bde2ec0bc90d959b529c97aea20385043 Cr-Commit-Position: refs/heads/master@{#29442}

Patch Set 1 #

Patch Set 2 : Don't start incremental marking while the linear allocation area is in an inconsistent state #

Total comments: 4

Patch Set 3 : Add testing, and improve comments #

Patch Set 4 : Merge up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -28 lines) Patch
M src/heap/incremental-marking.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M src/heap/spaces.cc View 1 2 6 chunks +61 lines, -15 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 9 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153004/20001
5 years, 8 months ago (2015-04-22 13:00:48 UTC) #2
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-22 13:01:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-22 13:24:35 UTC) #6
Hannes Payer (out of office)
looking good, test case would be fantastic https://codereview.chromium.org/1077153004/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1077153004/diff/20001/src/heap/spaces.cc#newcode2428 src/heap/spaces.cc:2428: // this. ...
5 years, 8 months ago (2015-04-22 14:06:21 UTC) #7
Erik Corry Chromium.org
https://codereview.chromium.org/1077153004/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1077153004/diff/20001/src/heap/spaces.cc#newcode2428 src/heap/spaces.cc:2428: // this. On 2015/04/22 14:06:21, Hannes Payer wrote: > ...
5 years, 5 months ago (2015-06-29 14:45:31 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153004/40001
5 years, 5 months ago (2015-06-29 14:51:12 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 15:18:18 UTC) #12
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-06-30 07:07:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153004/60001
5 years, 5 months ago (2015-07-02 12:37:02 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-02 13:27:33 UTC) #17
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/5000650bde2ec0bc90d959b529c97aea20385043 Cr-Commit-Position: refs/heads/master@{#29442}
5 years, 5 months ago (2015-07-02 13:27:47 UTC) #18
Michael Achenbach
5 years, 5 months ago (2015-07-06 13:58:16 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1212063005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert, see:
https://code.google.com/p/chromium/issues/detail?id=506875.

Powered by Google App Engine
This is Rietveld 408576698