Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1077153003: Throw when attaching a stack trace to an object fails. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Throw when attaching a stack trace to an object fails. R=jarin@chromium.org BUG=chromium:478011 LOG=N Committed: https://crrev.com/8cf289ca4fcfb10c15d1840706f89a3636456f7e Cr-Commit-Position: refs/heads/master@{#27941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M src/isolate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-478011.js View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
5 years, 8 months ago (2015-04-20 13:22:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153003/1
5 years, 8 months ago (2015-04-20 13:23:04 UTC) #3
Jarin
lgtm
5 years, 8 months ago (2015-04-20 13:25:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153003/1
5 years, 8 months ago (2015-04-20 13:34:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2137)
5 years, 8 months ago (2015-04-20 13:56:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153003/1
5 years, 8 months ago (2015-04-20 14:20:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 14:41:05 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:41:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf289ca4fcfb10c15d1840706f89a3636456f7e
Cr-Commit-Position: refs/heads/master@{#27941}

Powered by Google App Engine
This is Rietveld 408576698