Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test.dart

Issue 1077103002: Handle setter without getter for compounds in SemanticSendVisitor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2dart.status ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test.dart b/tests/compiler/dart2js/semantic_visitor_test.dart
index cdacd2c0781fc48a0776af853d350a5d64c64216..658f55130d914abe9b7bdc71550ce47b68641975 100644
--- a/tests/compiler/dart2js/semantic_visitor_test.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test.dart
@@ -2075,6 +2075,14 @@ const Map<String, List<Test>> SEND_TESTS = const {
const Visit(VisitKind.VISIT_SUPER_FIELD_SETTER_POSTFIX,
getter: 'field(A#a)', setter: 'setter(B#a)',
operator: '++')),
+
+ const Test(
+ '''
+ set topLevel(var value) { }
+ m() => topLevel++;
+ ''',
+ const Visit(VisitKind.ERROR_UNRESOLVED_POSTFIX,
+ operator: '++')),
],
'Constructor invocations': const [
const Test(
@@ -4117,7 +4125,8 @@ class SemanticSendTestVisitor extends SemanticTestVisitor {
ErroneousElement element,
IncDecOperator operator,
arg) {
- // TODO: implement errorUnresolvedPostfix
+ visits.add(new Visit(
+ VisitKind.ERROR_UNRESOLVED_POSTFIX, operator: operator));
}
@override
@@ -4594,5 +4603,7 @@ enum VisitKind {
ERROR_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- // TODO(johnniwinther): Add tests for error cases.
+ ERROR_UNRESOLVED_POSTFIX,
+
+ // TODO(johnniwinther): Add tests for more error cases.
}
« no previous file with comments | « tests/co19/co19-dart2dart.status ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698