[bindings] Utilize branch prediction macro LIKELY for V8 to native value conversion.

[bindings] Utilize branch prediction macro LIKELY for V8 to native value conversion.

R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193535

[vivekg, 2015-04-10 09:22:44]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-04-10 09:22:44]

PTAL. Had missed this earlier but realized we could use this while reviewing
bashi's patch [1].

[1] https://codereview.chromium.org/1051753003/#msg5

[haraken, 2015-04-10 09:25:27]

LGTM

(But note that the basic rule is we only use LIKELY/UNLIKELY only in places
where it really matters for performance.)

[vivekg, 2015-04-10 09:27:58]

On 2015/04/10 at 09:25:27, haraken wrote:
> LGTM
> 
> (But note that the basic rule is we only use LIKELY/UNLIKELY only in places
where it really matters for performance.)

Yes I understand. Have gone thr' some of the kernel modules where the merits and
demerits of using LIKELY/UNLIKELY have been listed. 
I thought these are safe places for the usage of LIKELY hence went ahead with
the patch. 

Good to land?

[haraken, 2015-04-10 09:48:36]

> > (But note that the basic rule is we only use LIKELY/UNLIKELY only in places
> where it really matters for performance.)
> 
> Yes I understand. Have gone thr' some of the kernel modules where the merits
and
> demerits of using LIKELY/UNLIKELY have been listed. 
> I thought these are safe places for the usage of LIKELY hence went ahead with
> the patch. 
> 
> Good to land?

Yeah, this LIKELY wouldn't be controversial and is good for consistency.

[vivekg, 2015-04-10 09:56:53]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-04-10 09:57:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1077083002/1

[commit-bot: I haz the power, 2015-04-10 11:37:22]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193535