Implement a basic Site Engagement Score service.

Implement a basic Site Engagement Score service.

The Site Engagement Service will be used to perform resource allocation
(such as battery or disk) based on how much users interact with the
origin in question.

BUG=464234
Committed: https://crrev.com/edf5e08744111e2b97f3bff0258b04cdcdd9d98f
Cr-Commit-Position: refs/heads/master@{#326431}

[benwells, 2015-04-15 22:57:34]

benwells@chromium.org changed reviewers:
+ raymes@chromium.org

[benwells, 2015-04-15 22:57:34]

Raymes for first pass review...

[raymes, 2015-04-16 01:13:55]

lgtm with nits

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_helper.h (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:18: class
SiteEngagementHelper
nit: Could you add a comment for this class?

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:23: 
nit: // WebContentsObserver overrides.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.cc:37: url.GetOrigin();
nit: remove this line

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:16: // Stores and retrieves
the engagement score of a origin.
nit: an origin

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:19: // engaged with a origin
- the higher it is, the more engagement the user has
nit: an origin

[benwells, 2015-04-16 05:15:27]

benwells@chromium.org changed reviewers:
+ thestig@chromium.org

[benwells, 2015-04-16 05:15:28]

+thestig for an owners review.

This is just a partial implementation to allow us to get started.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_helper.h (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:18: class
SiteEngagementHelper
On 2015/04/16 01:13:55, raymes wrote:
> nit: Could you add a comment for this class?

Done.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:23: 
On 2015/04/16 01:13:55, raymes wrote:
> nit: // WebContentsObserver overrides.

Done. I also made it private.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.cc:37: url.GetOrigin();
On 2015/04/16 01:13:55, raymes wrote:
> nit: remove this line

Done.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:16: // Stores and retrieves
the engagement score of a origin.
On 2015/04/16 01:13:55, raymes wrote:
> nit: an origin

Done.

https://codereview.chromium.org/1077063002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:19: // engaged with a origin
- the higher it is, the more engagement the user has
On 2015/04/16 01:13:55, raymes wrote:
> nit: an origin

Done.

[benwells, 2015-04-16 05:28:35]

benwells@chromium.org changed reviewers:
+ asvitkine@chromium.org, jochen@chromium.org
- thestig@chromium.org

[benwells, 2015-04-16 05:28:35]

+jochen for overall owners review (thestig is travelling)
+asvitkine for histograms

[jochen (gone - plz use gerrit), 2015-04-17 09:27:41]

it's not clear to me what this feature is about.

could you please send an intent to implement with a design to chromium-dev?

[benwells, 2015-04-20 06:29:58]

On 2015/04/17 09:27:41, jochen wrote:
> it's not clear to me what this feature is about.
> 
> could you please send an intent to implement with a design to chromium-dev?

Fair enough. There has been a lot of discussion about this feature (which is
more commonly known as Karma) among the security and Fizz groups, however it
should be made more public.

I'll send an 'intent to explore' as it is very experimental. I've put together a
brief design doc outlining the feature, once some security and fizz people have
reviewed it I'll send to chromium-dev and then we can continue here.

Thanks!

[benwells, 2015-04-22 09:31:20]

On 2015/04/20 06:29:58, benwells wrote:
> On 2015/04/17 09:27:41, jochen wrote:
> > it's not clear to me what this feature is about.
> > 
> > could you please send an intent to implement with a design to chromium-dev?
> 
> Fair enough. There has been a lot of discussion about this feature (which is
> more commonly known as Karma) among the security and Fizz groups, however it
> should be made more public.
> 
> I'll send an 'intent to explore' as it is very experimental. I've put together
a
> brief design doc outlining the feature, once some security and fizz people
have
> reviewed it I'll send to chromium-dev and then we can continue here.
> 
> Thanks!

Intent to implement posted here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/cUD77cEjMRw

[jochen (gone - plz use gerrit), 2015-04-22 14:51:36]

lgtm

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_helper.h (right):

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:35: 
nit. only one empty line

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service_factory.h (right):

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service_factory.h:40: };
disallow copy/assign

[Alexei Svitkine (slow), 2015-04-22 15:50:32]

lgtm

[benwells, 2015-04-22 22:54:21]

Patchset #5 (id:80001) has been deleted

[benwells, 2015-04-23 00:34:24]

The CQ bit was checked by benwells@chromium.org

[benwells, 2015-04-23 00:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org,
jochen@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1077063002/#ps100001
(title: "Feedback")

[benwells, 2015-04-23 00:34:33]

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_helper.h (right):

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_helper.h:35: 
On 2015/04/22 14:51:36, jochen wrote:
> nit. only one empty line

Done.

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service_factory.h (right):

https://codereview.chromium.org/1077063002/diff/40001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service_factory.h:40: };
On 2015/04/22 14:51:36, jochen wrote:
> disallow copy/assign

Done.

[commit-bot: I haz the power, 2015-04-23 00:35:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1077063002/100001

[commit-bot: I haz the power, 2015-04-23 02:45:30]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-04-23 02:46:16]

Patchset 5 (id:??) landed as
https://crrev.com/edf5e08744111e2b97f3bff0258b04cdcdd9d98f
Cr-Commit-Position: refs/heads/master@{#326431}

[wspowers7, 2016-03-10 16:58:00]

wspowers7@gmail.com changed reviewers:
+ wspowers7@gmail.com