Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1077043002:
bindings: v8::Handle -> v8::Local in CostumElementBinding (Closed)
|
Created:
5 years, 8 months ago by anujsharma Modified:
5 years, 8 months ago Reviewers:
haraken CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
Descriptionbindings: v8::Handle -> v8::Local in CostumElementBinding
BUG=424445
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193550
Patch Set 1 #Patch Set 2 : Fixed rebase issue #
Messages
Total messages: 18 (9 generated)
anujk.sharma@samsung.com changed reviewers: + haraken@chromium.org
On 2015/04/10 09:45:27, anujsharma wrote: > mailto:anujk.sharma@samsung.com changed reviewers: > + mailto:haraken@chromium.org PTAL
LGTM
On 2015/04/10 09:49:03, haraken wrote: > LGTM Thanks haraken for lgtm
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for Source/bindings/core/v8/ScriptString.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file Source/bindings/core/v8/ScriptString.cpp
Hunk #1 FAILED at 40.
Hunk #2 FAILED at 55.
Hunk #3 FAILED at 66.
3 out of 3 hunks FAILED -- saving rejects to file
Source/bindings/core/v8/ScriptString.cpp.rej
Patch: Source/bindings/core/v8/ScriptString.cpp
Index: Source/bindings/core/v8/ScriptString.cpp
diff --git a/Source/bindings/core/v8/ScriptString.cpp
b/Source/bindings/core/v8/ScriptString.cpp
index
066c7a2af196f32a1cfef7903be254fffac5de4f..a8d0fdb3de244a0aba40a7e17a19609093a98c00
100644
--- a/Source/bindings/core/v8/ScriptString.cpp
+++ b/Source/bindings/core/v8/ScriptString.cpp
@@ -40,7 +40,7 @@ ScriptString::ScriptString()
{
}
-ScriptString::ScriptString(v8::Isolate* isolate, v8::Handle<v8::String> string)
+ScriptString::ScriptString(v8::Isolate* isolate, v8::Local<v8::String> string)
: m_isolate(isolate)
, m_string(SharedPersistent<v8::String>::create(string, m_isolate))
{
@@ -55,10 +55,10 @@ ScriptString& ScriptString::operator=(const ScriptString&
string)
return *this;
}
-v8::Handle<v8::String> ScriptString::v8Value()
+v8::Local<v8::String> ScriptString::v8Value()
{
if (isEmpty())
- return v8::Handle<v8::String>();
+ return v8::Local<v8::String>();
return m_string->newLocal(isolate());
}
@@ -66,7 +66,7 @@ ScriptString ScriptString::concatenateWith(const String&
string)
{
v8::Isolate* nonNullIsolate = isolate();
v8::HandleScope handleScope(nonNullIsolate);
- v8::Handle<v8::String> targetString = v8String(nonNullIsolate, string);
+ v8::Local<v8::String> targetString = v8String(nonNullIsolate, string);
if (isEmpty())
return ScriptString(nonNullIsolate, targetString);
return ScriptString(nonNullIsolate, v8::String::Concat(v8Value(),
targetString));
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for Source/bindings/core/v8/ScriptString.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file Source/bindings/core/v8/ScriptString.cpp
Hunk #1 FAILED at 40.
Hunk #2 FAILED at 55.
Hunk #3 FAILED at 66.
3 out of 3 hunks FAILED -- saving rejects to file
Source/bindings/core/v8/ScriptString.cpp.rej
Patch: Source/bindings/core/v8/ScriptString.cpp
Index: Source/bindings/core/v8/ScriptString.cpp
diff --git a/Source/bindings/core/v8/ScriptString.cpp
b/Source/bindings/core/v8/ScriptString.cpp
index
066c7a2af196f32a1cfef7903be254fffac5de4f..a8d0fdb3de244a0aba40a7e17a19609093a98c00
100644
--- a/Source/bindings/core/v8/ScriptString.cpp
+++ b/Source/bindings/core/v8/ScriptString.cpp
@@ -40,7 +40,7 @@ ScriptString::ScriptString()
{
}
-ScriptString::ScriptString(v8::Isolate* isolate, v8::Handle<v8::String> string)
+ScriptString::ScriptString(v8::Isolate* isolate, v8::Local<v8::String> string)
: m_isolate(isolate)
, m_string(SharedPersistent<v8::String>::create(string, m_isolate))
{
@@ -55,10 +55,10 @@ ScriptString& ScriptString::operator=(const ScriptString&
string)
return *this;
}
-v8::Handle<v8::String> ScriptString::v8Value()
+v8::Local<v8::String> ScriptString::v8Value()
{
if (isEmpty())
- return v8::Handle<v8::String>();
+ return v8::Local<v8::String>();
return m_string->newLocal(isolate());
}
@@ -66,7 +66,7 @@ ScriptString ScriptString::concatenateWith(const String&
string)
{
v8::Isolate* nonNullIsolate = isolate();
v8::HandleScope handleScope(nonNullIsolate);
- v8::Handle<v8::String> targetString = v8String(nonNullIsolate, string);
+ v8::Local<v8::String> targetString = v8String(nonNullIsolate, string);
if (isEmpty())
return ScriptString(nonNullIsolate, targetString);
return ScriptString(nonNullIsolate, v8::String::Concat(v8Value(),
targetString));
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by anujk.sharma@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/1077043002/#ps20001 (title: "Fixed rebase issue")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077043002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193550 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
