Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 1076973002: [Media Router] Reland: MediaRouter interfaces with stub implementations. (Closed)

Created:
5 years, 8 months ago by imcheng (use chromium acct)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "MediaRouter interfaces with stub implementations." Original patch: crrev.com/1020743003. The GN file is changed so that the tests are no longer depending on the target that was causing link errors on debug GN builds. TEST=git cl try + mac_chromium_gn_dbg + win8_chromium_gn_dbg [Media Router] MediaRouter interfaces with stub implementations. - Updated Media Router data classes. - Added MediaRouter interface with a stub MediaRouterImpl class. - MRImpl is a KeyedService and is instantiated via its BrowserContextKeyedServiceFactory implementation. - Added MediaRoutesObserver / MediaSinksObserver interfaces which are used by MediaRouter API. BUG=461815, 464199 Committed: https://crrev.com/2ae6fd35a8ce0dbaebd478efa342474adea63378 Cr-Commit-Position: refs/heads/master@{#324662}

Patch Set 1 #

Patch Set 2 : Remove some deps from BUILD.gn #

Patch Set 3 : separate keyed service factory classes into own target; isolate from unit tests #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -27 lines) Patch
M chrome/browser/media/router/BUILD.gn View 1 2 3 2 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_route.h View 3 chunks +6 lines, -11 lines 0 comments Download
A chrome/browser/media/router/media_router.h View 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_router_impl.h View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_router_impl.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_router_impl_factory.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_router_impl_factory.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_routes_observer.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_routes_observer.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_sink.h View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/media/router/media_sink.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/media/router/media_sink_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/media/router/media_sinks_observer.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_sinks_observer.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_source.h View 1 chunk +25 lines, -3 lines 0 comments Download
M chrome/browser/media/router/media_source.cc View 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
imcheng
5 years, 8 months ago (2015-04-10 06:10:45 UTC) #2
mark a. foltz
lgtm
5 years, 8 months ago (2015-04-10 16:48:03 UTC) #4
mark a. foltz
On 2015/04/10 16:48:03, mark a. foltz wrote: > lgtm FYI, I've usually seen a re-land ...
5 years, 8 months ago (2015-04-10 16:49:20 UTC) #5
xhwang
On 2015/04/10 16:49:20, mark a. foltz wrote: > On 2015/04/10 16:48:03, mark a. foltz wrote: ...
5 years, 8 months ago (2015-04-10 16:59:23 UTC) #6
xhwang
Also, I assume your PS1 is the original CL (crrev.com/1020743003), right? It's a good practice ...
5 years, 8 months ago (2015-04-10 17:02:22 UTC) #8
imcheng
Updated title. Yes, PS1 is the final PS from the original patch. I should've labelled ...
5 years, 8 months ago (2015-04-10 17:05:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076973002/60001
5 years, 8 months ago (2015-04-10 17:07:10 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-10 17:59:30 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2ae6fd35a8ce0dbaebd478efa342474adea63378 Cr-Commit-Position: refs/heads/master@{#324662}
5 years, 8 months ago (2015-04-10 18:00:23 UTC) #14
mark a. foltz
5 years, 8 months ago (2015-04-10 18:11:18 UTC) #15
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698