SkJpegCodec

src/codec/SkJpegUtility.h

+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+
+#ifndef SkJpegUtility_DEFINED
+#define SkJpegUtility_DEFINED
+
+#include "SkImageDecoder.h"
+#include "SkStream.h"
+
+#include <setjmp.h>
+// stdio is needed for jpeglib
+#include <stdio.h>
+#include "jpeglib.h"
+#include "jerror.h"
+
+/*
+ * Error handling struct
+ */
+struct skjpeg_error_mgr : jpeg_error_mgr {
+    jmp_buf fJmpBuf;
+};
+
+/*
+ * Error handling function
+ */
+void skjpeg_err_exit(j_common_ptr cinfo);
+
+/*
+ * Source handling struct for that allows libjpeg to use our stream object
+ */
+struct skjpeg_source_mgr : jpeg_source_mgr {
+    skjpeg_source_mgr(SkStream* stream);
+
+    SkStream* fStream; // unowned
+    enum {
+        // TODO (msarett): Experiment with different buffer sizes.
+        // This size was chosen because it matches SkImageDecoder.
+        kBufferSize = 1024
+    };
+    SkAutoTDeleteArray<uint8_t> fBuffer;

[scroggo, 2015/04/14 13:10:33]

This can just be:

uint8_t fBuffer[kBufferSize];

[msarett, 2015/04/14 19:30:36]

You are right.  I have had several misunderstandings on this but this is finally
correct.

The srcMgr was originally stack allocated which I had to change.  Then I
erroneously thought that this buffer would also be on the stack if I didn't
change how it was allocated.

Now that you suggest it, it is quite obvious that the buffer will simply be
owned by the source_mgr if it is allocated in this way.

+};
+
+#endif