Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: lib/runtime/dart/core.js

Issue 1076883003: Initial support for runtime function types and type checking (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/isolate.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/core.js
diff --git a/lib/runtime/dart/core.js b/lib/runtime/dart/core.js
index 4d899fa2581959b36e98ee76c106ff0837c76da0..77934cdcfb199e6d61ec7d0cb4fcea6496024f41 100644
--- a/lib/runtime/dart/core.js
+++ b/lib/runtime/dart/core.js
@@ -79,15 +79,15 @@ var core;
return _js_helper.Primitives.applyFunction(f, positionalArguments, namedArguments == null ? null : Function[_toMangledNames](namedArguments));
}
static [_toMangledNames](namedArguments) {
- let result = dart.as(dart.map(), Map$(String, dynamic));
+ let result = dart.as(dart.map(), Map$(String, dart.dynamic));
namedArguments.forEach(dart.as((symbol, value) => {
result.set(_symbolToString(dart.as(symbol, Symbol)), value);
- }, dart.throw_("Unimplemented type (Symbol, dynamic) → void")));
+ }, dart.functionType(dart.void, [Symbol, dart.dynamic])));
return result;
}
}
let Comparator$ = dart.generic(function(T) {
- class Comparator extends Function {}
+ let Comparator = dart.typedef('Comparator', () => dart.functionType(int, [T, T]));
return Comparator;
});
let Comparator = Comparator$();
@@ -1118,7 +1118,7 @@ var core;
});
let Iterable = Iterable$();
let _Generator$ = dart.generic(function(E) {
- class _Generator extends Function {}
+ let _Generator = dart.typedef('_Generator', () => dart.functionType(E, [int]));
return _Generator;
});
let _Generator = _Generator$();
@@ -2064,7 +2064,7 @@ var core;
throw new UnsupportedError(`Illegal path character ${segment}`);
}
}
- }, dart.throw_("Unimplemented type (String) → void")));
+ }, dart.functionType(dart.void, [String])));
}
static [_checkWindowsPathReservedCharacters](segments, argumentError, firstSegment) {
if (firstSegment === void 0)
@@ -2077,7 +2077,7 @@ var core;
throw new UnsupportedError("Illegal character in path");
}
}
- }, dart.throw_("Unimplemented type (String) → void")));
+ }, dart.functionType(dart.void, [String])));
}
static [_checkWindowsDriveLetter](charCode, argumentError) {
if (dart.notNull(Uri[_UPPER_CASE_A]) <= dart.notNull(charCode) && dart.notNull(charCode) <= dart.notNull(Uri[_UPPER_CASE_Z]) || dart.notNull(Uri[_LOWER_CASE_A]) <= dart.notNull(charCode) && dart.notNull(charCode) <= dart.notNull(Uri[_LOWER_CASE_Z])) {
@@ -2351,7 +2351,7 @@ var core;
if (path != null) {
result = Uri[_normalize](path, start, end, dart.as(Uri[_pathCharOrSlashTable], List$(int)));
} else {
- result = pathSegments[exports.$map](dart.as((s) => Uri[_uriEncode](dart.as(Uri[_pathCharTable], List$(int)), dart.as(s, String)), dart.throw_("Unimplemented type (String) → dynamic")))[exports.$join]("/");
+ result = pathSegments[exports.$map](dart.as((s) => Uri[_uriEncode](dart.as(Uri[_pathCharTable], List$(int)), dart.as(s, String)), dart.functionType(dart.dynamic, [String])))[exports.$join]("/");
}
if (dart.dload(result, 'isEmpty')) {
if (isFile)
@@ -2381,7 +2381,7 @@ var core;
result.write("=");
result.write(Uri.encodeQueryComponent(dart.as(value, String)));
}
- }, dart.throw_("Unimplemented type (String, String) → void")));
+ }, dart.functionType(dart.void, [String, String])));
return result.toString();
}
static [_makeFragment](fragment, start, end) {
@@ -2792,7 +2792,7 @@ var core;
dart.dsetindex(map, Uri.decodeQueryComponent(dart.as(key, String), {encoding: encoding}), Uri.decodeQueryComponent(dart.as(value, String), {encoding: encoding}));
}
return map;
- }, dart.throw_("Unimplemented type (dynamic, String) → dynamic"))), Map$(String, String));
+ }, dart.functionType(dart.dynamic, [dart.dynamic, String]))), Map$(String, String));
}
static parseIPv4Address(host) {
// Function error: (String) → void
@@ -2809,7 +2809,7 @@ var core;
error('each part must be in the range of `0..255`');
}
return byte;
- }, dart.throw_("Unimplemented type (String) → dynamic")))[exports.$toList](), List$(int));
+ }, dart.functionType(dart.dynamic, [String])))[exports.$toList](), List$(int));
}
static parseIPv6Address(host, start, end) {
if (start === void 0)
@@ -3039,7 +3039,7 @@ var core;
function _symbolMapToStringMap(map) {
if (map == null)
return null;
- let result = new (Map$(String, dynamic))();
+ let result = new (Map$(String, dart.dynamic))();
map.forEach((key, value) => {
result.set(_symbolToString(key), value);
});
« no previous file with comments | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/isolate.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698