Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: lib/runtime/dart/_isolate_helper.js

Issue 1076883003: Initial support for runtime function types and type checking (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: uncomment code Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/_isolate_helper.js
diff --git a/lib/runtime/dart/_isolate_helper.js b/lib/runtime/dart/_isolate_helper.js
index 4eb067ea4fc2f3f4113b92cbc8b5aa6ff04d6d30..358f780da78544489a70a8963ec29d619af67a45 100644
--- a/lib/runtime/dart/_isolate_helper.js
+++ b/lib/runtime/dart/_isolate_helper.js
@@ -111,7 +111,7 @@ var _isolate_helper;
}
serializeMap(x) {
let serializeTearOff = this.serialize;
- return new core.List.from(['map', x.keys[core.$map](dart.as(serializeTearOff, dart.throw_("Unimplemented type (dynamic) → dynamic")))[core.$toList](), x.values[core.$map](dart.as(serializeTearOff, dart.throw_("Unimplemented type (dynamic) → dynamic")))[core.$toList]()]);
+ return new core.List.from(['map', x.keys[core.$map](dart.as(serializeTearOff, dart.functionType(dynamic, [dynamic])))[core.$toList](), x.values[core.$map](dart.as(serializeTearOff, dart.functionType(dynamic, [dynamic])))[core.$toList]()]);
Jennifer Messerly 2015/04/09 18:44:28 shouldn't this be `dart.dynamic`?
vsm 2015/04/09 19:52:24 Done.
}
serializeJSObject(x) {
if (!!x.constructor && x.constructor !== Object) {
@@ -829,9 +829,9 @@ var _isolate_helper;
return !!self.postMessage;
}
});
- class _MainFunction extends core.Function {}
- class _MainFunctionArgs extends core.Function {}
- class _MainFunctionArgsMessage extends core.Function {}
+ let _MainFunction = dart.typedef('_MainFunction', () => dart.functionType(dynamic, []));
+ let _MainFunctionArgs = dart.typedef('_MainFunctionArgs', () => dart.functionType(dynamic, [dynamic]));
+ let _MainFunctionArgsMessage = dart.typedef('_MainFunctionArgsMessage', () => dart.functionType(dynamic, [dynamic, dynamic]));
let _getEventData = Symbol('_getEventData');
let _startIsolate = Symbol('_startIsolate');
let _log = Symbol('_log');
@@ -955,7 +955,7 @@ var _isolate_helper;
let replyPort = dart.dindex(msg, 'replyPort');
IsolateNatives.spawn(dart.as(dart.dindex(msg, 'functionName'), core.String), dart.as(dart.dindex(msg, 'uri'), core.String), dart.as(dart.dindex(msg, 'args'), core.List$(core.String)), dart.dindex(msg, 'msg'), false, dart.as(dart.dindex(msg, 'isSpawnUri'), core.bool), dart.as(dart.dindex(msg, 'startPaused'), core.bool)).then(dart.as((msg) => {
dart.dinvoke(replyPort, 'send', msg);
- }, dart.throw_("Unimplemented type (List<dynamic>) → dynamic")), {
+ }, dart.functionType(dynamic, [core.List])), {
onError: (errorMessage) => {
dart.dinvoke(replyPort, 'send', new core.List.from([_SPAWN_FAILED_SIGNAL, errorMessage]));
}

Powered by Google App Engine
This is Rietveld 408576698