Initial support for runtime function types and type checking

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 import 'dart:io' show Directory, File;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
@@ skipping 286 matching lines @@
     if (rules.isBoolType(t)) return 'boolean';
     return null;
   }
 
   @override
   visitFunctionTypeAlias(FunctionTypeAlias node) {
     // If we've already emitted this class, skip it.
     var type = node.element.type;
     if (_pendingClasses.remove(node.element) == null) return null;
 
-    var classDecl = new JS.ClassDeclaration(new JS.ClassExpression(
-        new JS.Identifier(type.name),
-        _emitTypeName(rules.provider.functionType), []));
+    var name = type.name;
+    var closure = new JS.ArrowFun([], _emitTypeName(node.element.type, true));
+    var result = js.statement('let # = dart.typedef(#, #);', [

[Jennifer Messerly, 2015/04/09 18:44:29]

maybe a little cleaner:

'let # = dart.typedef(#, () => #);'

and you can skip the manual `var closure = new JS.ArrowFun([], ...` line

[vsm, 2015/04/09 19:52:25]

Done.

+      new JS.Identifier(name),
+      js.string(name, "'"),
+      closure
+    ]);
 
-    return _finishClassDef(type, classDecl);
+    return _finishClassDef(type, result);
+    // if (isPublic(name)) _addExport(name);

[Jennifer Messerly, 2015/04/09 18:44:29]

remove?

[vsm, 2015/04/09 19:52:25]

Done.

+    // return result;
   }
 
   @override
   JS.Expression visitTypeName(TypeName node) => _emitTypeName(node.type);
 
   @override
   JS.Statement visitClassTypeAlias(ClassTypeAlias node) {
     // If we've already emitted this class, skip it.
     var type = node.element.type;
     if (_pendingClasses.remove(node.element) == null) return null;
@@ skipping 764 matching lines @@
       /// The renamer would handle this, but it would prefer to rename the
       /// temporary used for the private symbol. Instead rename the parameter.
       return new JSTemporary('${name.substring(1)}');
     }
 
     if (_isTemporary(e)) return new JSTemporary(e.name);
 
     return new JS.Identifier(name);
   }
 
-  JS.Expression _emitTypeName(DartType type) {
+  JS.ArrayInitializer _emitTypeNames(List<DartType> types) {
+    return new JS.ArrayInitializer(types.map(_emitTypeName).toList());
+  }
+
+  JS.ObjectInitializer _emitTypeProperties(Map<String, DartType> types) {
+    var properties = <JS.Property>[];
+    types.forEach((name, type) {
+      var key = new JS.LiteralString(name);
+      var value = _emitTypeName(type);
+      properties.add(new JS.Property(key, value));
+    });
+    return new JS.ObjectInitializer(properties);
+  }
+
+  JS.Expression _emitTypeName(DartType type, [bool lowerTypedef = false]) {

[Jennifer Messerly, 2015/04/09 18:44:29]

named arg?

[vsm, 2015/04/09 19:52:25]

Done.

+    if (type.isVoid) {
+      // The void type is not defined in core.

[Jennifer Messerly, 2015/04/09 18:44:29]

dynamic too?

[vsm, 2015/04/09 19:52:25]

Done.

+      return js.call('dart.void');
+    }
+
     var name = type.name;
     var element = type.element;
-    if (name == '') {
+    if (name == '' || lowerTypedef && type is FunctionType) {
+      if (type is FunctionType) {
+        // TODO(vsm): Support all parameter types.

[Jennifer Messerly, 2015/04/09 18:44:29]

can you elaborate on this?

[vsm, 2015/04/09 19:52:25]

Obsolete.  Removed.

+        var returnType = type.returnType;
+        var parameterTypes = type.normalParameterTypes;
+        var optionalTypes = type.optionalParameterTypes;
+        var namedTypes = type.namedParameterTypes;
+        if (namedTypes.isEmpty) {
+          if (optionalTypes.isEmpty) {
+            return js.call('dart.functionType(#, #)', [
+              _emitTypeName(returnType),
+              _emitTypeNames(parameterTypes)
+            ]);
+          } else {
+            return js.call('dart.functionType(#, #, #)', [
+              _emitTypeName(returnType),
+              _emitTypeNames(parameterTypes),
+              _emitTypeNames(optionalTypes)
+            ]);
+          }
+        } else {
+          assert(optionalTypes.isEmpty);
+          return js.call('dart.functionType(#, #, #)', [
+            _emitTypeName(returnType),
+            _emitTypeNames(parameterTypes),
+            _emitTypeProperties(namedTypes)
+          ]);
+        }
+      }
       // TODO(jmesserly): remove when we're using coercion reifier.
       return _unimplementedCall('Unimplemented type $type');
     }
 
     var typeArgs = null;
     if (type is ParameterizedType) {
       // TODO(jmesserly): this is a workaround for an analyzer bug, see:
       // https://github.com/dart-lang/dev_compiler/commit/a212d59ad046085a626dd8d16881cdb8e8b9c3fa
       if (type is! FunctionType || element is FunctionTypeAlias) {
         var args = type.typeArguments;
@@ skipping 1384 matching lines @@
 
     // TODO(jmesserly): in many cases marking the end will be unncessary.
     printer.mark(_location(node.end));
   }
 
   String _getIdentifier(AstNode node) {
     if (node is SimpleIdentifier) return node.name;
     return null;
   }
 }