Refactor net::BackoffEntry to not require subclassing

components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_TEST_UTILS_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_TEST_UTILS_H_
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/single_thread_task_runner.h"
+#include "base/time/clock.h"
+#include "base/time/tick_clock.h"
 #include "base/time/time.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h"
 #include "net/base/backoff_entry.h"
 #include "net/log/capturing_net_log.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 83 matching lines @@
 
   base::TimeDelta GetDelay() const;
 
  protected:
   // Overrides of DataReductionProxyConfigServiceClient
   base::Time Now() const override;
   net::BackoffEntry* GetBackoffEntry() override;
 
  private:
   // A clock which returns a fixed value in both base::Time and base::TimeTicks.
-  class TestTickClock {
+  class TestTickClock : public base::Clock, public base::TickClock {
    public:
     TestTickClock(const base::Time& initial_time);
 
-    // Returns the current base::TimeTicks
-    base::TimeTicks NowTicks() const;
+    // base::TickClock implementation.
+    base::TimeTicks NowTicks() override;
 
-    // Returns the current base::Time
-    base::Time Now() const;
+    // base::Clock implementation.
+    base::Time Now() override;
 
     // Sets the current time.
     void SetTime(const base::Time& time);
 
    private:
     base::Time time_;
   };
 
-  // A net::BackoffEntry which uses an injected base::TickClock to control
-  // the backoff expiration time.
-  class TestBackoffEntry : public net::BackoffEntry {
-   public:
-    TestBackoffEntry(const BackoffEntry::Policy* const policy,
-                     const TestTickClock* tick_clock);
-
-   protected:
-    // Override of net::BackoffEntry.
-    base::TimeTicks ImplGetTimeNow() const override;
-
-   private:
-    const TestTickClock* tick_clock_;
-  };
-
-  TestTickClock tick_clock_;
-  TestBackoffEntry test_backoff_entry_;
+  mutable TestTickClock tick_clock_;

[mmenke, 2015/04/10 15:50:43]

Why does this have to be mutable?

[johnme, 2015/04/10 16:23:36]

It was because base::Clock::Now is non-const, hence TestTickClock::Now must be
non-const, but TestDataReductionProxyConfigServiceClient::Now must be const
since DataReductionProxyConfigServiceClient::Now is const.

I've made TestTickClock no longer inherit from base::Clock (I only added that
for symmetry), so Now can be const again and it no longer needs to be mutable.
However this is now a little asymmetric, with one method const and the other
non-const :-|

Alternatively, if you'd rather, I could make
DataReductionProxyConfigServiceClient::Now be non-const, as it's never currently
used in a const manner?

[mmenke, 2015/04/10 16:26:37]

I'd go ahead and make DataReductionProxyConfigServiceClient::Now non-const, for
simplicity, but don't have strong feelings on the subject.

+  net::BackoffEntry test_backoff_entry_;
 };
 
 // Test version of |DataReductionProxyService|, which permits mocking of various
 // methods.
 class MockDataReductionProxyService : public DataReductionProxyService {
  public:
   MockDataReductionProxyService(
       scoped_ptr<DataReductionProxyCompressionStats> compression_stats,
       DataReductionProxySettings* settings,
       net::URLRequestContextGetter* request_context);
@@ skipping 257 matching lines @@
   scoped_ptr<DataReductionProxySettings> settings_;
 
   TestDataReductionProxyParams* params_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyTestContext);
 };
 
 }  // namespace data_reduction_proxy
 
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_TEST_UTILS_H_