Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: chrome/browser/chromeos/net/network_portal_detector_impl.h

Issue 1076853003: Refactor net::BackoffEntry to not require subclassing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address pneubeck's review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_
6 #define CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_ 6 #define CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 bool StartDetectionIfIdle() override; 79 bool StartDetectionIfIdle() override;
80 void SetStrategy(PortalDetectorStrategy::StrategyId id) override; 80 void SetStrategy(PortalDetectorStrategy::StrategyId id) override;
81 void OnLockScreenRequest() override; 81 void OnLockScreenRequest() override;
82 82
83 // NetworkStateHandlerObserver implementation: 83 // NetworkStateHandlerObserver implementation:
84 void DefaultNetworkChanged(const NetworkState* network) override; 84 void DefaultNetworkChanged(const NetworkState* network) override;
85 85
86 // PortalDetectorStrategy::Delegate implementation: 86 // PortalDetectorStrategy::Delegate implementation:
87 int NoResponseResultCount() override; 87 int NoResponseResultCount() override;
88 base::TimeTicks AttemptStartTime() override; 88 base::TimeTicks AttemptStartTime() override;
89 base::TimeTicks GetCurrentTimeTicks() override; 89 base::TimeTicks NowTicks() override;
90 90
91 private: 91 private:
92 friend class ::NetworkingConfigTest; 92 friend class ::NetworkingConfigTest;
93 friend class NetworkPortalDetectorImplTest; 93 friend class NetworkPortalDetectorImplTest;
94 friend class NetworkPortalDetectorImplBrowserTest; 94 friend class NetworkPortalDetectorImplBrowserTest;
95 95
96 struct DetectionAttemptCompletedReport { 96 struct DetectionAttemptCompletedReport {
97 DetectionAttemptCompletedReport(); 97 DetectionAttemptCompletedReport();
98 98
99 DetectionAttemptCompletedReport(const std::string network_name, 99 DetectionAttemptCompletedReport(const std::string network_name,
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 DetectionAttemptCompletedReport attempt_completed_report_; 269 DetectionAttemptCompletedReport attempt_completed_report_;
270 270
271 base::WeakPtrFactory<NetworkPortalDetectorImpl> weak_factory_; 271 base::WeakPtrFactory<NetworkPortalDetectorImpl> weak_factory_;
272 272
273 DISALLOW_COPY_AND_ASSIGN(NetworkPortalDetectorImpl); 273 DISALLOW_COPY_AND_ASSIGN(NetworkPortalDetectorImpl);
274 }; 274 };
275 275
276 } // namespace chromeos 276 } // namespace chromeos
277 277
278 #endif // CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_ 278 #endif // CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698