Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076853002: fix for perf regression on ugamsolutions / msaa16 (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for perf regression on ugamsolutions / msaa16 BUG=skia: Committed: https://skia.googlesource.com/skia/+/62db8ba68b980245e0927b792747864ebd6fcb6a

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -119 lines) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 2 2 chunks +66 lines, -23 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 3 chunks +28 lines, -93 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-09 14:47:07 UTC) #2
robertphillips
lgtm + a nit https://codereview.chromium.org/1076853002/diff/20001/src/gpu/GrBatchFontCache.h File src/gpu/GrBatchFontCache.h (right): https://codereview.chromium.org/1076853002/diff/20001/src/gpu/GrBatchFontCache.h#newcode101 src/gpu/GrBatchFontCache.h:101: GrTexture* getTexture(GrMaskFormat format) { this-> ...
5 years, 8 months ago (2015-04-09 14:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076853002/40001
5 years, 8 months ago (2015-04-09 15:01:10 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 15:22:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/62db8ba68b980245e0927b792747864ebd6fcb6a

Powered by Google App Engine
This is Rietveld 408576698