Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 1076833002: Correctly wrap uri.js into a function. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly wrap uri.js into a function. R=jkummerow@chromium.org Committed: https://crrev.com/14d46f52aa7cc8a9e87b7b4f441fd5d11fd82383 Cr-Commit-Position: refs/heads/master@{#27712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -333 lines) Patch
M src/uri.js View 1 chunk +329 lines, -333 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
This is mainly to change uri.js to the same layout as the other .js files.
5 years, 8 months ago (2015-04-09 14:07:48 UTC) #1
Yang
On 2015/04/09 14:07:48, Yang wrote: > This is mainly to change uri.js to the same ...
5 years, 8 months ago (2015-04-09 14:08:17 UTC) #2
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-09 14:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076833002/1
5 years, 8 months ago (2015-04-09 14:21:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 19:35:00 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 19:35:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14d46f52aa7cc8a9e87b7b4f441fd5d11fd82383
Cr-Commit-Position: refs/heads/master@{#27712}

Powered by Google App Engine
This is Rietveld 408576698