Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: Source/bindings/core/v8/V8EventListenerList.h

Issue 1076783002: Support non-function object values assigned to EventHandler attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: drop (now) pointless assert Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8EventListenerList.h
diff --git a/Source/bindings/core/v8/V8EventListenerList.h b/Source/bindings/core/v8/V8EventListenerList.h
index 9271197dc36c3377201e9baec05f7798788bc34e..596ad8b4ec475916c3728a24822f982ea5474ac5 100644
--- a/Source/bindings/core/v8/V8EventListenerList.h
+++ b/Source/bindings/core/v8/V8EventListenerList.h
@@ -89,9 +89,7 @@ PassRefPtr<V8EventListener> V8EventListenerList::findOrCreateWrapper(v8::Local<v
{
v8::Isolate* isolate = scriptState->isolate();
ASSERT(isolate->InContext());
- if (!value->IsObject()
- // Non-callable attribute setter input is treated as null (no wrapper)
- || (isAttribute && !value->IsFunction()))
+ if (!value->IsObject())
return nullptr;
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
« Source/bindings/core/v8/V8EventListener.cpp ('K') | « Source/bindings/core/v8/V8EventListener.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698