chrome/browser/ui/cocoa/one_click_signin_view_controller.mm - Issue 107673002: OneClickSigninBubbleView: Update the bubble form to reflect new bubble/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

Issue 107673002: OneClickSigninBubbleView: Update the bubble form to reflect new bubble/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address sky@ comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/one_click_signin_view_controller.h ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

index 8d27c1ae4f20d2e4ef5a1884e513044468dcb068..5e4d9677656be4c8629a1f96ae0a26f03caf024c 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

@@ -161,6 +161,11 @@ void ShiftOriginY(NSView* view, CGFloat amount) {

[GTMUILocalizerAndLayoutTweaker

sizeToFitFixedWidthTextField:messageTextField_];

+ ShiftOriginY(titleTextField_, totalYOffset);

+ totalYOffset +=

+ [GTMUILocalizerAndLayoutTweaker

+ sizeToFitFixedWidthTextField:titleTextField_];

if (closeButton_)

ShiftOriginY(closeButton_, totalYOffset);

@@ -225,6 +230,11 @@ void ShiftOriginY(NSView* view, CGFloat amount) {

messageColor:[NSColor blackColor]

linkColor:linkColor];

+ // Make the "Advanced" link font as large as the "Learn More" link.

+ [[advancedLink_ cell] setFont:font];

+ [advancedLink_ sizeToFit];

// Size to fit.

[[informativePlaceholderTextField_ cell] setAttributedStringValue:

[informativeTextView_ attributedString]];