Reland of 'Make allow_subannotations more robust'

Reland of 'Make allow_subannotations more robust'

From here: http://crrev.com/1001183002#ps120001

This patch makes the recipe engine parse and re-emit subannotations when allow_subannotations is True.  This means that any of the subannotator's steps which are duplicates of other steps executed will be disambiguated.  When an allow_subannotations step is actually emits annotations, an (end) step is emitted after it is done to have something to hang metadata on (it also conveniently communicates when we re-enter recipes).

BUG=466409
R=iannucci@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294732

[luqui, 2015-04-08 22:25:34]

ptal

[luqui, 2015-04-08 22:25:50]

luqui@chromium.org changed reviewers:
+ iannucci@chromium.org

[luqui, 2015-04-08 22:25:50]

ptal

[iannucci, 2015-04-08 22:26:53]

lgtm

[luqui, 2015-04-08 22:27:14]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-04-08 22:27:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076643002/20001

[commit-bot: I haz the power, 2015-04-08 22:31:50]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294732

[kjellander_chromium, 2015-04-09 12:49:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1072823002/ by kjellander@chromium.org.

The reason for reverting is: Makes the WebRTC Windows perf bots hang when the
upload to the perf dashboard is about to happen.
Examples:
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge...
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester
http://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester
http://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester
For some strange reason it only affects Win7 and 8, not XP.
.

[iannucci, 2015-04-09 16:43:45]

Looks like a bug in how log lines are handled

On Thu, Apr 9, 2015, 05:49  <kjellander@chromium.org> wrote:

> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1072823002/ by kjellander@chromium.org.
>
> The reason for reverting is: Makes the WebRTC Windows perf bots hang when
> the
> upload to the perf dashboard is about to happen.
> Examples:
> http://build.chromium.org/p/client.webrtc/builders/Win32%
> 20Release%20%5Blarge%20tests%5D
> http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester
> http://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester
> http://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester
> For some strange reason it only affects Win7 and 8, not XP.
> .
>
> https://codereview.chromium.org/1076643002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.